Community
Participate
Working Groups
And, I mean completely empty. Used to say "there are no build notes for current build." and then have some "instructions to committers". I'd prefer not to have the link at all, if no build notes, but have a vague memory that was difficult to do on "dynamic php page".
Turns out to be a case of accidental genius. Many months ago I added --prune-empty-dirs to the rsync command which moves builds from build machine, to downloads machine -- "just because it seemed like a good idea". I didn't notice any differences, but that's what causes this. There is an empty directory, buildnotes, on build machine version (empty if there are no build notes), but after 'rsync' there is no "buildnotes" directory any more. The "genius" part is this makes it very easy to NOT have the text and link at all, if there is no directory. If there are build notes, then there will be a directory, and the text and link will appear. So, that's direction I'll take to "fix" this bug. In addition, I will move it to "last" line of the "list" of initial links: Instead of: View the test results for the current build. View the repositories used for the current build. View build notes for the current build. How to verify a download We'll have following when there are build notes: View the test results for the current build. View the repositories used for the current build. How to verify a download View build notes for the current build. And, if there are no build notes, will be View the test results for the current build. View the repositories used for the current build. How to verify a download That is, easier to notice "somethings different" if additional link added to end of a list. Plus, looks like one sentence is missing a period. I will also put those "directions to committers" in the wiki at http://wiki.eclipse.org/Platform-releng/Platform_Build_Automated sine won't be so easy to know, if there is never a link there.
http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=dc644a90aa8292f1703cd59dd10e6630e9f4daf0 I'll be "testing" that this works as expected over this weekend (5/31/2014) by adding some releng build notes, or something, (and then removing them) ... but the first test (5/30/2014) ... will be just to make sure the link does not show up, but otherwise the page acts as normal.
(see previous comment)
(In reply to David Williams from comment #3) Forgot a semi-colon, causing syntax error, and whole page to not display. http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=12ee5cbc7b8f3d137245dce306fe8313364ae741
Found a few other errrors, and made some small improvements: http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=c54f7f52e554a68aa5ef78e858d172cb7e3bead0 And for Saturday afternoon's build, I ut buildnotes_releng.txt in releng.tools just to test all that end still works.
(In reply to David Williams from comment #5) > Found a few other errrors, and made some small improvements: > > http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/ > commit/?id=c54f7f52e554a68aa5ef78e858d172cb7e3bead0 > > And for Saturday afternoon's build, I ut buildnotes_releng.txt in > releng.tools just to test all that end still works. I've discovered that the "build notes" work as expected, if "manually" put in place, but are no longer collected (properly) from components, and opened bug 436300 for that. While that could safely be fixed for Luna, I won't since a) I sure hope we would not need any ... and b) discovered one bundle still has an old one in its source tree (bug 436301) so is not worth churning all that up, this last week of Luna. On a related note, the page looks like of ugly and out of place (as do some other "extra info" pages) so in bug 436282 I've suggested we "wrap" those with the normal "Eclipse theme" code. In the mean time, I'll count this as "verified", since I did verify it works correctly if file is copied into place. (but ... will now delete that file and directory, so one else can really "see it" till the other bugs are fixed ... and for now, there will be just one less link at top of DL page).
