Community
Participate
Working Groups
While fixing bug 436219, and then testing it and finding buildnotes were no longer collected, I also happened to notice that the astview bundle has (and apparently old) "buildnotes" file: .../eclipse.jdt.ui/org.eclipse.jdt.astview/buildnotes_astview.html I suspect this is not worth fixing for "the last week of Luna" simply because that'd change the qualifier, which would effect the feature qualifier, etc., ... and we all know what trouble that's been lately. But, suggest that it be removed (or .. updated?) in maintenance (and master) after we release Luna.
Sorry, meant to paste in the bug number regarding the "collection" issue, since once that's fixed, it will "start to show up" ... but, I don't plan to fix that until after Luna is released.
(In reply to David Williams from comment #1) > Sorry, meant to paste in the bug number regarding the "collection" issue, > since once that's fixed, it will "start to show up" ... but, I don't plan to > fix that until after Luna is released. I can't believe I forgot it twice! ... it is bug 436300.
Also, in looking at the fix for bug 436300, apparently that used to (also) copy jdt_core_style.css ... which admittedly is from another component (jdt.core) ... but I don't plan to copy any css files any longer, and if anything, rely on wrapping such "buildnotes" in the standard "Eclipse style" themes (bug 436282). So if anything special really is required for JDT, let me know, but I'd prefer a consistent look and feel across all components.
The AST view isn't built, so no problem to fix this. Fixed with http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=dc0070e7f6af84dc77d2ce88e44068d4014748f5
(In reply to Dani Megert from comment #4) > The AST view isn't built, so no problem to fix this. > > Fixed with > http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/ > ?id=dc0070e7f6af84dc77d2ce88e44068d4014748f5 Thanks ... you say it is "not part of build" ... which I assume means is not listed as a module ... but I discovered this by looking in "target" build area ... so ideally, I'd suggest removing it from "head" as well ... if it's not used (unless, it is going to be used in near future). Just helps lesson "false alarms" of searches :) if nothing else. Thanks again,
(In reply to David Williams from comment #5) > Thanks ... you say it is "not part of build" ... which I assume means is not > listed as a module ... No, I meant, it's not part of the SDK or any other officially produced artifact. But, yes, it's not listed in the module ;-). > so ideally, I'd suggest removing it from "head" as well ... if it's > not used (unless, it is going to be used in near future). It is used. This is one of the JDT tools that we offer via JDT update site. We build this manually whenever some interesting changes got made to the tool(s).
(In reply to Dani Megert from comment #6) > (In reply to David Williams from comment #5) > > Thanks ... you say it is "not part of build" ... which I assume means is not > > listed as a module ... > > No, I meant, it's not part of the SDK or any other officially produced > artifact. But, yes, it's not listed in the module ;-). > > > > so ideally, I'd suggest removing it from "head" as well ... if it's > > not used (unless, it is going to be used in near future). > > It is used. This is one of the JDT tools that we offer via JDT update site. > We build this manually whenever some interesting changes got made to the > tool(s). Thanks for clarifying. FWIW, this gave me the idea of putting them in main Eclipse repo, one way or another, and opened enhancement: Bug 436399 - Consider building "tools" and putting in (only) Eclipse repo Just seems simpler, at least for community to find them.
Hope you don't mind re-opening the same bug, but the "BETA_JAVA9" branch also needs the "buildnotes" file removed or renamed. You can see them show up at See http://download.eclipse.org/eclipse/downloads/drops4/Y20160513-1000/ (They used to not show up since that functionality was broken :/ but now that it is fixed, they do).
Fixed in BETA_JAVA9 with http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=3f02c0e0fea53454fe71bbeeff336e3ac3ba00a5
Dani, please don't cherry-pick changes into the BETA_JAVA9 branch. The right way to keep the branches in sync is to merge master into BETA_JAVA9.
(In reply to Markus Keller from comment #10) > Dani, please don't cherry-pick changes into the BETA_JAVA9 branch. Sorry about that.
