Bug 433097 - Icons of all sizes should have same basic color scheme
Summary: Icons of all sizes should have same basic color scheme
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.4 M7   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 426260
  Show dependency tree
 
Reported: 2014-04-19 03:59 EDT by David Williams CLA
Modified: 2014-04-28 10:53 EDT (History)
2 users (show)

See Also:


Attachments
eclipse16.png with orange c (664 bytes, image/png)
2014-04-23 13:21 EDT, Markus Keller CLA
no flags Details
eclipse16.gif (559 bytes, image/gif)
2014-04-28 02:14 EDT, David Williams CLA
no flags Details
slightly cleaned up eclipse16 PNG file (1.10 KB, image/png)
2014-04-28 02:19 EDT, David Williams CLA
no flags Details
attachment 1 "in use" (50.98 KB, image/png)
2014-04-28 02:38 EDT, David Williams CLA
no flags Details
attachment 3 "in use" (48.80 KB, image/png)
2014-04-28 02:40 EDT, David Williams CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description David Williams CLA 2014-04-19 03:59:46 EDT
This issue -- of "no orange in small icons" has been discussed in great detail in umbrella bug of 426260, but the more I look at it, and the more I work with it, the more nasty it seems, to me. It not only "looks bad" and unprofessional, there have been a few cases I've been genuinely surprised when I've clicked on some "blue and white" icon for some action and then prompted with an orange blue and white icon in some confirmation dialog -- sort of had to "look twice" to make sure I had not clicked on wrong thing to begin with. 

Another case I've discovered lately is that if the windows display is set at 100% (96 dpi) then the icon is small enough that the blue and white one is chosen to represent the executable. 

But, if I change "dpi" to 125% or 150% it gets "large enough", I guess, that somehow Windows decides it needs a larger icon and it happens to be orange blue and white. This is especially back, since our application is not that sensitive to "dpi" so its still "blue and white" there (see bug 110035). 

Not our worst usability problem ... but, is a usability problem that deserves its own bug.
Comment 1 Dani Megert CLA 2014-04-22 08:04:29 EDT
(In reply to David Williams from comment #0)
> This issue -- of "no orange in small icons" has been discussed in great
> detail in umbrella bug of 426260, but the more I look at it, and the more I
> work with it, the more nasty it seems, to me. It not only "looks bad" and
> unprofessional, there have been a few cases I've been genuinely surprised
> when I've clicked on some "blue and white" icon for some action and then
> prompted with an orange blue and white icon in some confirmation dialog --
> sort of had to "look twice" to make sure I had not clicked on wrong thing to
> begin with. 

+1.
Comment 2 Markus Keller CLA 2014-04-23 13:21:12 EDT
Created attachment 242247 [details]
eclipse16.png with orange c

This also works as "icon with border" for bug 428949
Comment 3 Dani Megert CLA 2014-04-24 04:47:58 EDT
(In reply to Markus Keller from comment #2)
> Created attachment 242247 [details]
> eclipse16.png with orange c
> 
> This also works as "icon with border" for bug 428949

I like it.
Comment 4 David Williams CLA 2014-04-25 16:28:25 EDT
(In reply to Dani Megert from comment #3)
> (In reply to Markus Keller from comment #2)
> > Created attachment 242247 [details]
> > eclipse16.png with orange c
> > 
> > This also works as "icon with border" for bug 428949
> 
> I like it.

I like it too, and apologies for not "getting back" to this yet, but think I'll have time over next few days (still in time for M7). I still want to investigate the whole "family" of sizes and colors, and think we can do a little better tweaking color intensities depending on size. 

I studied this a lot in school, and my early carrier in "Human Factors" at IBM ... though from searching the web, appears there's no clear reference that is "icon specific". Best I could come up with -- just to illustrate my point -- was 
http://personal.uncc.edu/lagaro/cwg/color/color_percept.html
or more specific to this issue: 
http://personal.uncc.edu/lagaro/cwg/color/Size-Area&Color.gif
or 
http://personal.uncc.edu/lagaro/cwg/color/SuccessiveCont.gif

So ... we'll see. There's probably no clear reference to "icon work" because a) its hard and b) normally designers just do it "by eye". But in our case, I think designer was only involved in main logo itself ... and everyone just assumed the icons were "small versions of that". 

But thanks Markus, yours will either be the foundation of what we go with, or if I can't clearly improve the "family" with little tweeks, then it will be what we go with.
Comment 5 Dani Megert CLA 2014-04-26 04:16:30 EDT
(In reply to David Williams from comment #4)
> (In reply to Dani Megert from comment #3)
> > (In reply to Markus Keller from comment #2)
> > > Created attachment 242247 [details]
> > > eclipse16.png with orange c
> > > 
> > > This also works as "icon with border" for bug 428949
> > 
> > I like it.
> 
> I like it too, and apologies for not "getting back" to this yet, but think
> I'll have time over next few days (still in time for M7).

Thanks!
Comment 6 David Williams CLA 2014-04-27 21:37:17 EDT
I've added the attached version to the Sunday night M7 I-build warm-up) [And, actually, got that started late, at 2030, instead of 2000.]

That includes re-creating the Windows ICO file, Mac ICNS, as well as simply replacing the 'eclipse16.png' file in the "product plugins". 

I will say I made progress on an even better one :) ... but I'm still learning about "multiple levels of transparency" and some of the ones I created (especially for 32 and 48 sizes) looked find in editors and in isolation, but when I looked at them in a local build, they looked like they had a bunch of "hair" growing out of the them -- illustrating the importance of viewing on different backgrounds, I guess. 

Plus, my "better" 16x16 was partially better because it was "bigger" than attached one, so if this one looks good in initial builds, I think we'd be safe using it for big 428949. 

[Note: I initially committed an eclipse16.gif that Markus sent me, but then noticed it was not correctly identified as "GIF" inside the file and some programs would not open it (though, others I guess ignored extension and opened it as PNG file) ... and I quickly tried to produce a proper "GIF", and checked that in ... and then noticed it did not look very good, losing some pixels in converting from PNG to GIF. ... I'll look at that some more to see if I did something "wrong" or if we need to "recreate" proper GIF ... I intend this just as a reminder that should be fixed ... even though we don't currently use it, we are including it "just in case" some distribution needs it.].
Comment 7 David Williams CLA 2014-04-28 02:14:50 EDT
Created attachment 242375 [details]
eclipse16.gif

cleaned up eclipse16 GIF file
Comment 8 David Williams CLA 2014-04-28 02:19:39 EDT
Created attachment 242376 [details]
slightly cleaned up eclipse16 PNG file

This PNG file was mostly "cleanup" to get the GIF image to export smoothly (some of the semi-transparent pieces were slightly off in the original attachment) 

And, while I was at it, added a little more orange, both in size and "brightness". 

I think it is  a little better ... but, getting hard for me to judge. 
(since I've been staring at pixels all weekend)
Comment 9 David Williams CLA 2014-04-28 02:25:04 EDT
And, am I seeing this right? On the Mac, there is no place to see a 16x16 icon, except for launcher? Not sure why I never noticed that before?
Comment 10 David Williams CLA 2014-04-28 02:38:48 EDT
Created attachment 242378 [details]
attachment 1 [details] "in use"
Comment 11 David Williams CLA 2014-04-28 02:40:23 EDT
Created attachment 242380 [details]
attachment 3 [details] "in use"

just showing some screen shots of what I see, on Windows. 

While I think the second one is slightly better ... still room for improvement, IMHO.
Comment 12 Markus Keller CLA 2014-04-28 04:40:36 EDT
Thanks for getting this in. I20140427-2030 looks good and "shippable" IMO (once the icons in PDE and Ant are updated as well).

Comment 8 looks slightly better on a white background, but the orange is too big and glaring on a darker background (window icon on top-left of the screenshots). At least on Windows, that's the icon people see most of the time.

(In reply to David Williams from comment #9)
> And, am I seeing this right? On the Mac, there is no place to see a 16x16
> icon, except for launcher? Not sure why I never noticed that before?

Not sitting on a Mac right now, but I think you should see it
- in the Debug menu and the launch config dialog for an Eclipse Application (PDE)
- in the Finder in List or Columns mode, or in the title of the Eclipse.app's Info window (Eclipse.icns)
Comment 13 Dani Megert CLA 2014-04-28 06:53:38 EDT
(In reply to Markus Keller from comment #12)
> Thanks for getting this in. I20140427-2030 looks good and "shippable" IMO
> (once the icons in PDE and Ant are updated as well).

I've done PDE UI and PDE API Tools with
http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=7163c615935abae2933c48ac1126b66146f4d342
Comment 14 Dani Megert CLA 2014-04-28 07:18:40 EDT
(In reply to Markus Keller from comment #12)
> Thanks for getting this in. I20140427-2030 looks good and "shippable" IMO
> (once the icons in PDE and Ant are updated as well).

And Ant with http://git.eclipse.org/c/platform/eclipse.platform.git/commit/?id=27c714f7375dcd851f90cd5addb7fdd01355fb4e
Comment 15 David Williams CLA 2014-04-28 10:32:37 EDT
(In reply to Markus Keller from comment #12)

> - in the Finder in List or Columns mode, or in the title of the
> Eclipse.app's Info window (Eclipse.icns)

Have confirmed its in the "columns" view, and in the title bar of "Get Info" ... and thus (the point) confirmed new 16x16 icon is in ICNS file. 

I'm fine closing this as fixed, if "shippable" is good enough ... which I agree with ... but, must confess, I'm hooked ... I may have a new hobby :) after seeing what Inkscape and Gimp can do.
Comment 16 Dani Megert CLA 2014-04-28 10:53:21 EDT
(In reply to David Williams from comment #15)
> I'm fine closing this as fixed, if "shippable" is good enough ... which I
> agree with ...

+1


> but, must confess, I'm hooked ... I may have a new hobby :)
> after seeing what Inkscape and Gimp can do.

We can follow up the hobby in a new bug ;-)