Community
Participate
Working Groups
from bug 426260 According to https://wiki.eclipse.org/Platform-releng/Updating_Branding#Icon_in_IDE some icons/images need the "eclipse16.gif" image but with a slight boarder of space, to fit the context they are used in. Specifically, the wiki says /org.eclipse.help.ui/icons/etool16/eclipse.gif (probably not used) /org.eclipse.pde.api.tools.ui/icons/full/obj16/eclipse_profile.gif /org.eclipse.pde.ui/icons/etool16/eclipse_launcher.gif /org.eclipse.pde.ui/icons/obj16/eclipse.gif I'll attach the version the designer provided.
Created attachment 240272 [details] gif with boarder Assume committer can rename with appropriate name, when added to repo.
Created attachment 240273 [details] regular "eclipse16.gif" for reference Wanted to add this "normal" eclipse16.gif for reference. They sort of look the same, to me :\
Created attachment 240307 [details] Screenshot with new icons The new icon looks cutoff at the top and left. It does not look good at all in the launch configuration dialog.
Created attachment 240308 [details] What it looks like with the no-border icon Using the reference no-border icon, you can see that the eclipse circle is larger and isn't cut off at the left.
To be honest, I can't really "see" what you mean ... but suggest you ask for improvements on bug 426260 ... or I could, if you'd prefer.
The icon in comment 4 looks better.
*** Bug 429541 has been marked as a duplicate of this bug. ***
A search for file name "*eclipse*.gif" should show all such icons. Dani, there's also /org.eclipse.ant.ui/icons/full/obj16/eclipse_obj.gif
Created attachment 240502 [details] eclipse16Smaller.gif The icon from comment 1 has a few problems: - blurry - too many white pixels in the corners (looks bad on a non-white background, e.g. when item is selected in Windows 7) - too long straight edges on left and top (comment 3) Looks like it has been created by resizing the original icon. I made an alternative version (eclipse16Smaller.gif) that retains the edges from the original eclipse.gif and solves these problems. Please take this one or ask the original designers for a smaller version.
(In reply to Markus Keller from comment #9) > I made an alternative version (eclipse16Smaller.gif) that retains the edges > from the original eclipse.gif and solves these problems. > > Please take this one or ask the original designers for a smaller version. On Bug 426260 we have several alternatives being discussed. We are likely going to use a 16px icon that will match the window icon. The only question is whether a 'smaller' icon with a border of whitespace is actually needed.
Created attachment 240506 [details] Screenshot of eclipse16 with selection on Windows Yes, I think we need the smaller version. The full 16x16 overlaps the item border in the Debug view and in the launch config dialog, and it also looks too massive when compared to other icons used along with this one.
(In reply to Markus Keller from comment #11) > Created attachment 240506 [details] > Screenshot of eclipse16 with selection on Windows > > Yes, I think we need the smaller version. The full 16x16 overlaps the item > border in the Debug view and in the launch config dialog, and it also looks > too massive when compared to other icons used along with this one. +1.
Ping!
So what is the conclusion? For /org.eclipse.pde.api.tools.ui/icons/full/obj16/eclipse_profile.gif /org.eclipse.pde.ui/icons/etool16/eclipse_launcher.gif /org.eclipse.pde.ui/icons/obj16/eclipse.gif Which icons should be used?
(In reply to Vikas Chandra from comment #14) > So what is the conclusion? > > For > /org.eclipse.pde.api.tools.ui/icons/full/obj16/eclipse_profile.gif > /org.eclipse.pde.ui/icons/etool16/eclipse_launcher.gif > /org.eclipse.pde.ui/icons/obj16/eclipse.gif > > Which icons should be used? A smaller version of /org.eclipse.platform/eclipse16.png
http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=d35fa2bbf1844ae13921ce21bdc6f7f820af3146 I created a new icon, picking colours from the newest icon set in Bug 426260. I will leave this bug open until we can see it in action in a build. Note that the icon looks terrible in high contrast mode, but so did the previous one as well as most of the icons in the launch configurations.
(In reply to Curtis Windatt from comment #16) > http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/ > ?id=d35fa2bbf1844ae13921ce21bdc6f7f820af3146 > I created a new icon, picking colours from the newest icon set in Bug 426260. > > I will leave this bug open until we can see it in action in a build. > > Note that the icon looks terrible in high contrast mode, but so did the > previous one as well as most of the icons in the launch configurations. This does not look good. The orange looks blurry. Please simply shrink the smaller version of /org.eclipse.platform/eclipse16.png (or gif if you prefer) as indicated in my previous comment.
(In reply to Dani Megert from comment #17) > This does not look good. The orange looks blurry. Please simply shrink the > smaller version of /org.eclipse.platform/eclipse16.png (or gif if you > prefer) as indicated in my previous comment. I don't think it looks blurry at all, but I can take another look, there is some transparency on that edge I could try taking out. Every time we've shrunk an existing icon down it has looked terrible. 16px is just not enough space.
(In reply to Curtis Windatt from comment #18) > (In reply to Dani Megert from comment #17) > > This does not look good. The orange looks blurry. Please simply shrink the > > smaller version of /org.eclipse.platform/eclipse16.png (or gif if you > > prefer) as indicated in my previous comment. > > I don't think it looks blurry at all, but I can take another look, there is > some transparency on that edge I could try taking out. I can attach a screenshot if required. But for sure it contains some orange colors which are not part of the official small 16x16 icon.
Created attachment 241976 [details] Screenshot of eclipse16Smaller.gif I could agree with the orange edge, but only if the eclipse16 and eclipse24 used elsewhere also get the orange. We can't leave the orange away in middle sizes and have it back in the tiny size. What's so bad about eclipse16Smaller from comment 9? Here's a screenshot that shows how it matches the appearance of the eclipse16 icon (in the window title).
(In reply to Markus Keller from comment #20) > Created attachment 241976 [details] > Screenshot of eclipse16Smaller.gif > > I could agree with the orange edge, but only if the eclipse16 and eclipse24 > used elsewhere also get the orange. We can't leave the orange away in middle > sizes and have it back in the tiny size. > > What's so bad about eclipse16Smaller from comment 9? Here's a screenshot > that shows how it matches the appearance of the eclipse16 icon (in the > window title). It would still be desirable to have orange in the smaller "windowImage" ones. I've not looked at these "small ones" yet. Any chance they could be used (i.e. have room) to make a slightly larger versions for the normal 16x16? [I've just not had time to try, and the last one appended to main bug, that had Orange in it, by "Timo"?, still looked a little blurry, to me].
http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=a79c9674e6e6746800ecac9818c5d99c539c3a41 I changed the icons in PDE to match the window image (icon from Markus in comment 9) If/when the window image is changed to have orange, we can reconsider adding the orange to PDE. Until then I don't want to put more time into this.
(In reply to Curtis Windatt from comment #22) > http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/ > ?id=a79c9674e6e6746800ecac9818c5d99c539c3a41 > I changed the icons in PDE to match the window image (icon from Markus in > comment 9) > > If/when the window image is changed to have orange, we can reconsider adding > the orange to PDE. Until then I don't want to put more time into this. Sounds reasonable to me. And now that you've said you don't want to put more time into it (don't blame you) you'll want to be sure to view on both light and dark themes when verifying. We've had some other cases where GIF doesn't look good on a dark back ground, presumably because it just has one level of transparency? so round edges might look jagged on dark background, even though they look smooth on light back ground ... but ... no idea if same issue here. Just a suggestion.
Marking as FIXED as I have no other changes planned. We can open a new bug in the RCs if we need to make additional tweaks.
(In reply to Curtis Windatt from comment #24) > Marking as FIXED as I have no other changes planned. We can open a new bug > in the RCs if we need to make additional tweaks. I've updated the icons again. See bug 433097 for details. (In reply to David Williams from comment #0) > /org.eclipse.help.ui/icons/etool16/eclipse.gif (probably not used) removed > /org.eclipse.pde.api.tools.ui/icons/full/obj16/eclipse_profile.gif renamed to eclipse16.png > /org.eclipse.pde.ui/icons/etool16/eclipse_launcher.gif renamed to eclipse16.png > /org.eclipse.pde.ui/icons/obj16/eclipse.gif renamed to eclipse16.png and deleted /org.eclipse.pde.ui/icons/dtool16/eclipse_launcher.gif
