Bug 430992 - [CSS] [dark theme] Search dialog tab headers are unstyled
Summary: [CSS] [dark theme] Search dialog tab headers are unstyled
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4   Edit
Hardware: PC All
: P3 normal with 1 vote (vote)
Target Milestone: 4.7 M5   Edit
Assignee: Lars Vogel CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy
: 501961 (view as bug list)
Depends on:
Blocks: 497562
  Show dependency tree
 
Reported: 2014-03-24 07:29 EDT by Robert Munteanu CLA
Modified: 2016-12-20 12:27 EST (History)
4 users (show)

See Also:

Attachments
unstyled tab headers (26.93 KB, image/png)
2014-03-24 07:29 EDT, Robert Munteanu CLA 		no flags Details
Search dialog dark theme (54.75 KB, image/png)
2016-12-13 06:24 EST, Fabian Pfaff CLA 		no flags Details
Windows 7 (34.82 KB, image/png)
2016-12-20 12:01 EST, Markus Keller CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Munteanu CLA 2014-03-24 07:29:05 EDT 
Eclipse build: eclipse-SDK-N20140323-2000-linux-gtk-x86_64
GTK 2 theme: adwaita
GTK 2 vesion: 2.24.22

When opening the default search dialog, the tab headings are unstyled and the active one is unreadable due to the background and foreground colors being very close.
Comment 1 Robert Munteanu CLA 2014-03-24 07:29:40 EDT 
Created attachment 241167 [details]
unstyled tab headers
Comment 2 Lars Vogel CLA 2014-03-24 08:06:05 EDT 
Robert, can you provide a patch for that?
Comment 3 Robert Munteanu CLA 2014-03-25 06:23:37 EDT 
Sorry, I can't provide a patch in the near future ...
Comment 4 Andrea Guarinoni CLA 2014-04-07 09:24:54 EDT 
All the 'TabFolder' widget usages should be replaced with 'CTabFolder' widgets to get a good look for themes. TabFolder inherits the system theme's appearance, while CTabFolder is intended to be customizable.
Comment 5 Lars Vogel CLA 2015-05-07 17:45:13 EDT 
Works fine in 4.5.0.I20150506-2000 under Linux
Comment 6 Lars Vogel CLA 2015-05-07 17:45:24 EDT 
Verified
Comment 7 Lars Vogel CLA 2015-05-07 17:45:46 EDT 
I used Ubuntu 15.04 with GTK3
Comment 8 Fabian Pfaff CLA 2016-12-13 06:21:00 EST 
Selected tab is still unstyled.
Comment 9 Fabian Pfaff CLA 2016-12-13 06:24:08 EST 
Created attachment 265845 [details]
Search dialog dark theme
Comment 10 Lars Vogel CLA 2016-12-13 06:26:47 EST 
(In reply to Fabian Pfaff from comment #8)
> Selected tab is still unstyled.

Also on Windows the TabFolder background color is using the system color. See Bug 508633.

I think we should follows Andreas advice from Comment 4 to switch to CTabFolder. I prepare a patch.
Comment 11 Eclipse Genie CLA 2016-12-13 06:28:33 EST 
New Gerrit change created: https://git.eclipse.org/r/87039
Comment 12 Lars Vogel CLA 2016-12-13 09:51:32 EST 
*** Bug 501961 has been marked as a duplicate of this bug. ***
Comment 13 Eclipse Genie CLA 2016-12-15 05:56:41 EST 
New Gerrit change created: https://git.eclipse.org/r/87214
Comment 14 Lars Vogel CLA 2016-12-15 05:58:24 EST 
Fabian, could you test this? You need to pull in the changes for eclipse.platform.text and eclipse.platform.ui and start a runtime Eclipse with both changes.
Comment 15 Fabian Pfaff CLA 2016-12-16 10:32:53 EST 
Works, looks good to me.
Comment 16 Lars Vogel CLA 2016-12-16 10:43:05 EST 
(In reply to Fabian Pfaff from comment #15)
> Works, looks good to me.

Thanks Fabian for the testing.
Comment 19 Markus Keller CLA 2016-12-20 12:01:34 EST 
Created attachment 265985 [details]
Windows 7

It's unnecessary and ugly. At least add a border.
Comment 20 Markus Keller CLA 2016-12-20 12:01:57 EST 
.
Comment 21 Eclipse Genie CLA 2016-12-20 12:27:04 EST 
New Gerrit change created: https://git.eclipse.org/r/87493
Comment 23 Lars Vogel CLA 2016-12-20 12:27:55 EST 
(In reply to Eclipse Genie from comment #22)
> Gerrit change https://git.eclipse.org/r/87493 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/
> ?id=2aaa3369051605d2e1d4ac677a5a1055b99d5011

Border added.