Bug 430620 - [Graphics] Some debug icons require updates
Summary: [Graphics] Some debug icons require updates
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 4.4   Edit
Hardware: PC Mac OS X
: P3 normal (vote)
Target Milestone: 4.4 M7   Edit
Assignee: Michael Rennie CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2014-03-18 11:27 EDT by Michael Rennie CLA
Modified: 2014-05-07 05:02 EDT (History)
5 users (show)

See Also:

Attachments
comparing old vs new image problems (82.93 KB, image/png)
2014-03-18 11:27 EDT, Michael Rennie CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Rennie CLA 2014-03-18 11:27:30 EDT 
Created attachment 240986 [details]
comparing old vs new image problems

With bug 426116 we added a much-needed refresh to the icons in Debug. However some of them need some tweaking to make them just right.

See the attachment.
Comment 1 Lars Vogel CLA 2014-03-18 12:08:53 EDT 
Tony, could you update the svg icons so that I can generate better png files from them?
Comment 2 Michael Rennie CLA 2014-03-18 13:48:17 EDT 
I pushed a commit to revert the offending icons to their gif's until we get some new png icons: http://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=0a8c673549ad7b979649f302480b56f94fe1db11

For the breakpoint / instruction pointer and debug icons, you should try to make them look exactly like the old ones to avoid confusion.
Comment 3 Paul Webster CLA 2014-03-27 13:20:31 EDT 
See https://git.eclipse.org/r/#/c/24017/
Comment 4 Lars Vogel CLA 2014-03-27 15:22:43 EDT 
(In reply to Paul Webster from comment #3)
> See https://git.eclipse.org/r/#/c/24017/

Merged with https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=702cd392ab09c5ba3c6fa069d0bf4b929b0321b2

I try to provide a Gerrit review for debug with the new icons.
Comment 5 Lars Vogel CLA 2014-03-27 15:31:18 EDT 
New icons and required code changes. Tony also did adjust some of the existing icons. I went though them and most of them looked better or I was not able to notice a change. 

https://git.eclipse.org/r/24023
Comment 6 Tony McCrary CLA 2014-03-31 20:41:04 EDT 
(In reply to Lars Vogel from comment #5)
> New icons and required code changes. Tony also did adjust some of the
> existing icons. I went though them and most of them looked better or I was
> not able to notice a change. 
> 
> https://git.eclipse.org/r/24023

Try the icons from this gerrit submission:
https://git.eclipse.org/r/#/c/24240/
Comment 7 Lars Vogel CLA 2014-04-01 00:41:17 EDT 
(In reply to Tony McCrary from comment #6)
> Try the icons from this gerrit submission:
> https://git.eclipse.org/r/#/c/24240/

Thanks Tony, applied with https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=780cc5208443e1d64d0c63635b5b8425608d60d8 I update the review for Michael.
Comment 8 Lars Vogel CLA 2014-04-01 00:56:44 EDT 
https://git.eclipse.org/r/#/c/24023/ has been updated. Michael, please have a look.