Bug 430162 - [CSS] [Dark] White color of active perspective button (ToolItem) or selected Toogle button (ToolItem)
Summary: [CSS] [Dark] White color of active perspective button (ToolItem) or selected ...
Status: RESOLVED WORKSFORME
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Lars Vogel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 430994 462059 (view as bug list)
Depends on: 463358
Blocks: 497562
  Show dependency tree
 
Reported: 2014-03-12 06:07 EDT by Lars Vogel CLA
Modified: 2019-01-22 08:30 EST (History)
7 users (show)

See Also:

Attachments
Screenshot (223.40 KB, image/png)
2014-03-12 09:16 EDT, Lars Vogel CLA 		no flags Details
Initial changes for the CSS support of the ToolItem (3.02 KB, text/plain)
2014-03-12 12:05 EDT, Daniel Rolka CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2014-03-12 06:07:37 EDT 
We should adjust the color of the selected button for the active perspective. Looks weird. 

Also I noted that the Product editor looks strange if the view is not selected.
Comment 1 Lars Vogel CLA 2014-03-12 06:08:09 EDT 
Andrea, can you provide a patch for the dark theme for the button selection color?
Comment 2 Andrea Guarinoni CLA 2014-03-12 09:00:35 EDT 
The button for active Perspective (the one natively on the top-right of the IDE) is not painted like a normal one and is forced by OS color.

However, can you attach screenshots of the issues? (behaviors are usually different on different OS/OS-themes..)
Comment 3 Lars Vogel CLA 2014-03-12 09:16:16 EDT 
Created attachment 240806 [details]
Screenshot
Comment 4 Andrea Guarinoni CLA 2014-03-12 10:49:06 EDT 
ok, thanks Lars, currently this cannot be addressed in CSS, it needs a patch to the engine for ToolItem, background-color/image for a selected ToolItem is inherited from the operative system theme.

(Probably this issue is a duplicate of Bug 427252)
Comment 5 Lars Vogel CLA 2014-03-12 11:02:18 EDT 
(In reply to Andrea Guarinoni from comment #4)
> ok, thanks Lars, currently this cannot be addressed in CSS, it needs a patch
> to the engine for ToolItem, background-color/image for a selected ToolItem
> is inherited from the operative system theme.

Daniel, can you suggest what we need to fix to make this stylable?
Comment 6 Daniel Rolka CLA 2014-03-12 12:05:19 EDT 
Created attachment 240816 [details]
Initial changes for the CSS support of the ToolItem

(In reply to Lars Vogel from comment #5)
> (In reply to Andrea Guarinoni from comment #4)
> > ok, thanks Lars, currently this cannot be addressed in CSS, it needs a patch
> > to the engine for ToolItem, background-color/image for a selected ToolItem
> > is inherited from the operative system theme.
> 
> Daniel, can you suggest what we need to fix to make this stylable?

You have to start with the changes that I attach with patch. Next there will be the 'on paint' event play with background of the ToolItem since as far I've seen it doesn't support your use case

Daniel
Comment 7 Lars Vogel CLA 2014-03-24 08:07:42 EDT 
*** Bug 430994 has been marked as a duplicate of this bug. ***
Comment 8 Stefan Winkler CLA 2015-03-28 10:42:29 EDT 
I have created Bug 463358. SWT does not support setting background colors or any other visual properties of the ToolItem besides the actual images. Without API for that, we cannot style the ToolItem so that it has a different look when it is selected.

Since that would mean a change to the SWT API and an implementation for all SWT platforms, I doubt that we can do anything in that direction for Mars :-(
Comment 9 Lars Vogel CLA 2015-05-07 02:14:48 EDT 
*** Bug 462059 has been marked as a duplicate of this bug. ***
Comment 10 Lars Vogel CLA 2019-01-22 08:30:43 EST 
Works fine for me in Ubuntu 18.10