Bug 42042 - [KeyBindings] Certain key-bindings still not working.
Summary: [KeyBindings] Certain key-bindings still not working.
Status: RESOLVED DUPLICATE of bug 42035
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P2 major (vote)
Target Milestone: ---   Edit
Assignee: Chris McLaren CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-08-26 18:08 EDT by Vijay Aravamudhan CLA
Modified: 2003-09-12 14:11 EDT (History)
7 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Vijay Aravamudhan CLA 2003-08-26 18:08:01 EDT
I am testing:
Version: 3.0.0
Build id: 200308261317

And the java multi-line comment shortcut key doesnt work. When I went to view
the key mapping, the view has completely changed
(Window>Preferences>Workbench>Keys). The older one was much better - since it
showed the tree structure, and we could quickly navigate to where we want to go,
instead of using the drop down. Could you please get the tree back?

I know that this is just a warm-up build for 3.0 M3, but I would like to provide
usability testing.
Comment 1 Dani Megert CLA 2003-08-27 03:07:29 EDT
Tom, please test and comment this one for the test pass.
He reports the bug against the rebuild. I verified that in that build the key
bindings work in general (e.g. Ctrl+j and Ctrl+SPACE)
Comment 2 Tom Hofmann CLA 2003-08-27 06:14:56 EDT
"Add Block Comment" works for me in the same build, but not "Remove Block
Comment". Both actions work when invoked using the menu. There is a keybinding
problem. 

Note that "Comment" (Ctrl+/) does not work either, while "Uncomment" still
works. I suspect this being caused by the new keybinding story.

One of the causes I can imagine is that when pressing Ctrl+Shift+/, I am really
pressing Ctrl+Shift+7 (being on a Swiss German keyboard where the slash is
Shift+7), which the new keybindng service might not be aware of.

What kind of keyboard layout are you using (US, German...)?

Changing summary since more than one action is affected.
Moving to Platform for comment.
Comment 3 Dani Megert CLA 2003-08-27 06:23:47 EDT
Confirm - same for me using fresh workspace.

Increasing severity since I have no clue on how I would change the key binding
with the new key binding preference dialog to something that would work.
Comment 4 Tod Creasey CLA 2003-08-27 09:54:00 EDT
*** Bug 42041 has been marked as a duplicate of this bug. ***
Comment 5 Markus Keller CLA 2003-08-27 09:55:40 EDT
I have a US keyboard layout.
- Comment/Uncomment: shortcuts work
- Add Block Commment / Remove Block Comment: shortcut's dont work
(and no way to change shortcuts in the new keybindings preferences, since the
dialog doesn't react to my fingering in any way)
Comment 6 Chris McLaren CLA 2003-08-27 10:43:20 EDT
re: Keys Preference Page
Yes there are changes here. In fact, its brand new code to work with the new commands API. Brand 
new unfinished code, unfortunately. Of course, its only 10:33 EST and i have until 3pm!

This new build is currently missing the following features
1. commands combo not filtering/changing in sync with category combo (FIXED)
1. visual indication of assignments of commands to key sequence (table is empty)
2. visual indication of assignments of key sequences to command (table is empty)
3. allowing selection of the items in the above tables to change the selction of the combo boxes.
4. proper enabled/disable states for the add, remove, and restore buttons.

believe it or not, however, it does work correctly in terms of adding and removing keybindings. 
though without 1 and 2 you are flying blind right now.

problems with specific keys not working i suspect the fault of one of the following:
1. key entry widget. (some problems under gtk right now)
2. we are using a new mechanism from SWT to gte first crack at keys. Steve N. suggests may be 
buggy.

as for "i like the older one better" all i can say is 
1. "aaarrrgghgh", and also.. 
2. "just wait until its finished first"
Comment 7 Douglas Pollock CLA 2003-08-27 11:21:54 EDT
The problem is that we are getting the shifted character from SWT rather than
the unshifted character, with no clear way to convert to the unshifted
character.  Previously, the hidden menu was automagically doing the conversion
at the operating system level.  So, to us, "Ctrl+Shift+/" looks like
"Ctrl+Shift+?" (US keyboard), and "Ctrl+/" looks like "Ctrl+Shift+/" (Swiss
German keyboard).

This breaks a bunch of key bindings, and discussions are underway as to what the
final solution will be -- for M3, and for later.
Comment 8 Tod Creasey CLA 2003-08-27 12:46:16 EDT
Going through all of the keybindings the only one that are currently set that 
have this problem are 

CTRL+SHIFT+/ org.eclipse.jdt.ui.edit.text.java.add.block.comment
CTRL+SHIFT+\ org.eclipse.jdt.ui.edit.text.java.remove.block.comment
CTRL+SHIFT+- org.eclipse.ui.edit.undo (emacs only)

The others that use modifier + shift use the uppercase character

ALT+SHIFT+< org.eclipse.ui.edit.text.goto.textStart  (emacs only)
ALT+SHIFT+> org.eclipse.ui.edit.text.goto.textEnd (emacs only)
ALT+SHIFT+? org.eclipse.ui.edit.text.contentAssist.contextInformation (emacs 
only)


To be able to handle the case where you have a lower case punctuation + shift 
in an accelerator will need more time than we have to give for M3. I think it 
would be best if the problem accelerators were removed for M3 until we have an 
adequate solution.
Comment 9 Dani Megert CLA 2003-08-27 12:53:50 EDT
Tod's assumption is true for US keyboard layout but not for others (see also
comment 7) depending on their keyboard layout.
Comment 10 Dani Megert CLA 2003-08-27 12:56:30 EDT
JDT UI and Text don't intend to remove/disable the key board shortcuts since it
is not feasible to tell which ones to disable. At the end we have no shortcuts.

Comment 11 Tod Creasey CLA 2003-08-27 13:00:52 EDT
After talking to Dani and Dirk it is clear that to workaround this problem and 
Bug 41908 for non English locales will result in dropping far more keybindings 
than are acceptable.

We will not be able to fix this problems for M3 and will have to leave this 
open.
Comment 12 Dirk Baeumer CLA 2003-08-27 13:04:30 EDT
This results in a M3 that might not be very usable when using a non US 
keyboard.
Comment 13 Douglas Pollock CLA 2003-09-03 14:56:11 EDT
See Bug 42035 for more information.  (dup?)
Comment 14 Chris McLaren CLA 2003-09-12 14:11:32 EDT
42035 covers the only remaining problem in this bug. closing as duplicate.

*** This bug has been marked as a duplicate of 42035 ***