Bug 420371 - fix testAbandonChange and testRestoreChange @ 2.4.4
Summary: fix testAbandonChange and testRestoreChange @ 2.4.4
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 2.0.2   Edit
Assignee: Tomasz Zarna CLA
QA Contact:
URL: http://ci.mylyn.org/job/mylyn-3.10.x/24/
Whiteboard:
Keywords: test
Depends on:
Blocks: 419162
  Show dependency tree
 
Reported: 2013-10-25 08:20 EDT by Tomasz Zarna CLA
Modified: 2013-10-25 11:17 EDT (History)
1 user (show)

See Also:

Attachments
mylyn/context/zip (24.32 KB, application/octet-stream)
2013-10-25 09:33 EDT, Tomasz Zarna CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomasz Zarna CLA 2013-10-25 08:20:49 EDT 
The same pair of tests fail on helios, juno, kepler and luna:

java.lang.AssertionError: Wrong # responses: 1, updated: 1
Expected: is <2>
     but: was <1>
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
	at org.junit.Assert.assertThat(Assert.java:865)
	at org.eclipse.mylyn.internal.gerrit.core.remote.TestRemoteObserver.waitForResponse(TestRemoteObserver.java:70)
	at org.eclipse.mylyn.internal.gerrit.core.remote.GerritReviewRemoteFactoryTest.testRestoreChange(GerritReviewRemoteFactoryTest.java:249)
	...
	
java.lang.AssertionError: Wrong # responses: 1, updated: 1
Expected: is <2>
     but: was <1>
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
	at org.junit.Assert.assertThat(Assert.java:865)
	at org.eclipse.mylyn.internal.gerrit.core.remote.TestRemoteObserver.waitForResponse(TestRemoteObserver.java:70)
	at org.eclipse.mylyn.internal.gerrit.core.remote.GerritReviewRemoteFactoryTest.testAbandonChange(GerritReviewRemoteFactoryTest.java:225)
	...
Comment 1 Tomasz Zarna CLA 2013-10-25 09:32:30 EDT 
Review: https://git.eclipse.org/r/#/c/17768/
Comment 2 Tomasz Zarna CLA 2013-10-25 09:33:59 EDT 
Created attachment 236900 [details]
mylyn/context/zip
Comment 3 Steffen Pingel CLA 2013-10-25 11:17:46 EDT 
Thanks. I cherry picked the fix onto the relevant branches for 3.10 and 3.9.2.