Bug 408849 - Maintain activation through DnD gestures
Summary: Maintain activation through DnD gestures
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.3   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 4.4 M2   Edit
Assignee: Eric Moffatt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 408756 (view as bug list)
Depends on:
Blocks: 415499
  Show dependency tree
 
Reported: 2013-05-23 13:26 EDT by Eric Moffatt CLA
Modified: 2021-10-20 03:44 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Moffatt CLA 2013-05-23 13:26:41 EDT 
There are a number of glitches that can be induced using DnD. Most notably we leave the result in a partially activated state...

For example if you drag a part out to detach it the result is that the 'active' style remains on the stack that it came from and it loses its focus.

The solution is to *force* a re-activation of the part once the DnD operation is finished...
Comment 1 Eric Moffatt CLA 2013-05-23 13:28:12 EDT 
Here's a first cut...may still need polish...

https://git.eclipse.org/r/13087
Comment 2 Eric Moffatt CLA 2013-05-23 13:31:50 EDT 
*** Bug 408756 has been marked as a duplicate of this bug. ***
Comment 3 Eric Moffatt CLA 2013-08-20 11:18:34 EDT 
Committed:

http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=2fdbb42289e99cf4488345d0482ee8bf30bea4f8

This does a few things:

- Switched from using the @Inject @Named(...ACTIVE_PART) mechanism to using the UILifeCycle ACTIVATE event (which is fired even if the active part doesn't really change (i.e. you drag it from one stack to another)

 - moves the management of the style for the stacks into the StackRenderer (and out of the WBWRenderer)

- Changes the StackDropHandler to merge a dragged stack by moving over the non-selected elements first to avoid churn.
Comment 4 Eric Moffatt CLA 2013-09-16 11:32:43 EDT 
Verified in 4.4.0.I20130915-2000.