Bug 40270 - "Link with editor" feature doesn't track activation
Summary: "Link with editor" feature doesn't track activation
Status: RESOLVED DUPLICATE of bug 39059
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.1   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Knut Radloff CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-07-16 17:16 EDT by Jared Burns CLA
Modified: 2003-07-29 12:29 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jared Burns CLA 2003-07-16 17:16:51 EDT
Build 20030716

The "Link with editor" feature seems to only track editor focus, not activation. 
The workbench supports just bringing editors to the top without giving them 
focus. The link with editor feature should update for this case.
Comment 1 Erich Gamma CLA 2003-07-17 09:55:07 EDT
JDT is consistent with the workbench and the link with editor is activated on 
a partActivated event. The current behaviour is OK by me, but moving to 
Platform UI for comments.
Comment 2 Knut Radloff CLA 2003-07-21 14:52:13 EDT
I think this is a bug if you consider the search result use case mentioned in 
bug 39059.
Adding Nick to cc list to see if he agrees.

*** This bug has been marked as a duplicate of 39059 ***
Comment 3 Nick Edgar CLA 2003-07-28 15:36:36 EDT
Intuitively I think it should sync with partBroughtToTop, not partActivated.
There may be some reason for the current behaviour, but I don't remember it.  
It would lead to more frequent changing of selection in the navigation views, 
but it would be more consistent.
Would have to handle the case where the view itself brings a different editor 
to front and ensure there are no cycles.

I suggest we try it.

Comment 4 Knut Radloff CLA 2003-07-29 12:29:24 EDT
The only possible cycle I see would be if a view changes editors to one other 
than the activated one when the view selection is set (e.g., editor A 
activated, selects element A, view opens editor B on selection change). I don't 
think this is a realistic scenario though.