Community
Participate
Working Groups
In any UI element in which a User adds a particpant, the user is provided with auto-completion suggestions.
I think what we're looking for here is something like providing an "Add Reviewer:" field in the Review section, so that the user doesn't have to go through the extra dialog. We could do this in two ways: 1. Make this an immediate submit, which would require a solution for bug 396315. 2. Do something like what we're doing with the "replying" to comment for bug 396079, thus supporting off-line adding of reviewers. I don't think it would be really that useful to tackle this one except as part of a more general solution. In particular, I think 2 may not be as natural, as it won't be obvious to users that they aren't actually making an immediate change on the back-end. Thoughts? Parenthetically, I think we should look at reorganzing things as part of all of this so that we show actions (+1, -1..) and People section as in other task editors.
(In reply to comment #1) > I don't think it would be really that useful to tackle this one except as part > of a more general solution. In particular, I think 2 may not be as natural, as > it won't be obvious to users that they aren't actually making an immediate > change on the back-end. I don't agree. Everything in the task editor is stored locally and I only sent to the server on submit. I don't see why we should make a difference for review participants.
(In reply to comment #2) > I don't agree. Everything in the task editor is stored locally and I only > sent to the server on submit. I don't see why we should make a difference > for review participants. Makes sense, I'd prefere to move in this direction everyway we can, and the biggest downside of current interface is having to open seperate dialog. Okay, so then here's a possible workflow: 1. User is given a field (in Reviewers section for now) with auto-complete. 2. User can enter values, which may or may not be implicitly verified with Gerrit API (bug 371733) 3. On submit, reviewers are actually added through API. I think I might be able to follow the Comments pattern as bug 396079 to make this work, but it won't be as straightforward. This raises the same set of issues as in all of the other related bugs. Until we get rid of the current workflow, we're going to be presenting a commit dialog to the user. I'm thinking that we don't need to worry about alerting the user that those review members will be added as well, we should just go ahead and do that as a side-effect..?
I don't see a good way to implement offline support for adding reviewers unless we resolve bug 370645 first. It think it would be weird if users had to use the publish dialog to add reviewers. I'm a bit confused since the summary describes a request for content assist which is already present in the Add Reviewers dialog?
(In reply to comment #4) > I don't see a good way to implement offline support for adding reviewers unless > we resolve bug 370645 first. It think it would be weird if users had to use the > publish dialog to add reviewers. That's precisely the point I was attempting to make earlier. :) > I'm a bit confused since the summary describes a request for content assist > which is already present in the Add Reviewers dialog? It was a bad summary coming from the original task. This bug is really about removing the dialog altogether. Changed to reflect that.
Mylyn has been restructured, and our issue tracking has moved to GitHub [1]. We are closing ~14K Bugzilla issues to give the new team a fresh start. If you feel that this issue is still relevant, please create a new one on GitHub. [1] https://github.com/orgs/eclipse-mylyn
