Bug 370645 - [editor] provide offline support when editing reviews in the task editor
Summary: [editor] provide offline support when editing reviews in the task editor
Status: CLOSED MOVED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 390377
  Show dependency tree
 
Reported: 2012-02-04 16:49 EST by Steffen Pingel CLA
Modified: 2012-12-19 18:22 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steffen Pingel CLA 2012-02-04 16:49:20 EST 
The review editor should have a behavior that is more consistent with the regular task editor workflow. It should also have offline support.

The Publish/Submit/Abandon dialog should be replaced by a section that is embedded in the task editor. This could be similar to the Bugzilla Actions section with a button group that offers three choices:

* Abandon Review
* Submit Patch Set 3
* Publish Draft Comments for Patch Set 3
  [Verify]
  [Review]
  [X] Submit

The comment should be entered through the regular New Comment field.
Comment 1 Sam Davis CLA 2012-06-18 18:18:03 EDT 
As an interim workaround, could the dialog be made modeless?
Comment 2 Miles Parker CLA 2012-11-28 14:24:29 EST 
Steffen, not clear how this is different from bug 344087. Consider changing summary or marking as dup.
Comment 3 Steffen Pingel CLA 2012-12-07 10:39:22 EST 
It's certainly related but it's different. Bug 344087 is about persisting the reviews model while this bug is about offline support for operations triggered from the task editor.
Comment 4 Miles Parker CLA 2012-12-07 15:21:23 EST 
As Steffen mentions, this *is* directly realtes to bug 390374, gerrit https://git.eclipse.org/r/#/c/9089/, where I propose using NEW_COMMENT as a way to manage comments. If we go all the way with this, we'll have a start of asolution to this one.
Comment 5 Eclipse Webmaster CLA 2022-11-15 11:45:08 EST 
Mylyn has been restructured, and our issue tracking has moved to GitHub [1].

We are closing ~14K Bugzilla issues to give the new team a fresh start. If you feel that this issue is still relevant, please create a new one on GitHub.

[1] https://github.com/orgs/eclipse-mylyn