Bug 37691 - [DND] Change EditorAreaDropAdapter to set DROP_COPY
Summary: [DND] Change EditorAreaDropAdapter to set DROP_COPY
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.1   Edit
Hardware: PC Windows 2000
: P1 critical (vote)
Target Milestone: 2.1.1   Edit
Assignee: Knut Radloff CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-05-15 11:15 EDT by Knut Radloff CLA
Modified: 2003-05-15 17:41 EDT (History)
3 users (show)

See Also:

Attachments
fix (3.78 KB, text/plain)
2003-05-15 11:16 EDT, Knut Radloff CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Knut Radloff CLA 2003-05-15 11:15:58 EDT 
build R2.1

The fixes to EditorAreaDropAdapter described in bug 37596 should be released in 
2_1_maintenance to address a data loss scenario on Solaris when dragging files 
to the editor without holding the copy modifier key. See bug 34648.
Comment 1 Knut Radloff CLA 2003-05-15 11:16:36 EDT 
Created attachment 4887 [details]
fix
Comment 2 Nick Edgar CLA 2003-05-15 11:45:06 EDT 
Approved to fix for 2.1.1.
Comment 3 Lynne Kues CLA 2003-05-15 15:27:21 EDT 
Reviewed code change and tested on win2k.
Comment 4 Knut Radloff CLA 2003-05-15 16:04:32 EDT 
Released fix in 2_1_maintenance. 
Reporter of bug 34648 already verified that replacing dragOver handling with 
dragEnter fixes the data loss problem. Should verify that changing drag 
operation works as well on Solaris if not already done (Veronika?).
Comment 5 Nick Edgar CLA 2003-05-15 16:24:59 EDT 
If this is the same patch that you had earlier made available for the Solaris 
DnD bug, then Jeff Halhead verified that it fixed the loss of data problem.
Comment 6 Knut Radloff CLA 2003-05-15 17:41:17 EDT 
The fix I released in 2_1_maintenance does slightly more in that it handles 
dragOperationChanged. This should actually be the correct fix (and what I sent 
to Jeff was "mostly correct") but I'd like to be sure.