Bug 37596 - [DND] EditorArea DropAdapter not handling DROP_DEFAULT correctly
Summary: [DND] EditorArea DropAdapter not handling DROP_DEFAULT correctly
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.1   Edit
Hardware: PC All
: P2 major (vote)
Target Milestone: 3.0   Edit
Assignee: Knut Radloff CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 37896 (view as bug list)
Depends on:
Blocks:
 
Reported: 2003-05-14 11:29 EDT by Veronika Irvine CLA
Modified: 2003-05-21 09:45 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Veronika Irvine CLA 2003-05-14 11:29:39 EDT 
1) DND.DROP_DEFAULT is not a valid style - DND.DROP_DEFAULT | DND.DROP_COPY is 
what you want.  In 3.0, with the style DND.DROP_DEFAULT, you will not get any 
drag and drop events in the DropTarget.  DND.DROP_DEFAULT simply means that if 
there are no modifier keys pressed, the application can choose what operation 
will be performed but if the application does not specify any operations that 
are supported by the DragSource, it will never be informed of the DND 
operation.

2) DND.DROP_DEFAULT should be handled in DragEnter and DragOperationChanged.  
Currently it is being done in DragOver which is not the time when the 
operation can change.  The current implementation results in cursor flicker 
and strange behaviour.
Comment 1 Knut Radloff CLA 2003-05-15 11:12:40 EDT 
For 3.0 should change EditorArea.addDropSupport to specify DROP_DEFAULT | 
DROP_COPY.
EditorAreaDropAdapter was changed to set the operation to DROP_COPY in 
dragEnter a while ago. Should add this to dragOperationChanged to handle 
modifier key press during drag.
Without these changes dropping a file on an editor is not possible.
Backport changes to EditorAreaDropAdapter to prevent data loss on Solaris (bug 
34648).
Comment 2 Knut Radloff CLA 2003-05-15 11:20:43 EDT 
Opened bug 37691 to consider releasing the changes to EditorAreaDropAdapter in 
2.1.1.
EditorArea does not need to be changed for 2.1.1
Comment 3 Knut Radloff CLA 2003-05-15 11:26:32 EDT 
Released fixes to EditorAreaDropAdapter and EditorArea to HEAD. Fixed in 
>20030515
Comment 4 Knut Radloff CLA 2003-05-21 09:45:22 EDT 
*** Bug 37896 has been marked as a duplicate of this bug. ***