Bug 374766 - All attachment sections should also display the camera icon to select "Attach Screenshot..."
Summary: All attachment sections should also display the camera icon to select "Attach...
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: 3.6   Edit
Hardware: PC Linux
: P3 trivial (vote)
Target Milestone: 3.8   Edit
Assignee: Frank Becker CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy
Depends on:
Blocks:
 
Reported: 2012-03-20 10:39 EDT by Jörg Thönnes CLA
Modified: 2012-05-24 03:03 EDT (History)
1 user (show)

See Also:

Attachments
Screen shot showing the attachment icon (3.42 KB, image/png)
2012-03-20 10:41 EDT, Jörg Thönnes CLA 		no flags Details
mylyn/context/zip (36.97 KB, application/octet-stream)
2012-05-23 16:00 EDT, Frank Becker CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jörg Thönnes CLA 2012-03-20 10:39:01 EDT 
In the same way as e.g. the JIRA connector does, all connectors (Bugzilla, Trac etc) should display the camera icon
besides the "Attach..." icon in the top right corner of the attachment section.

Will attach a screen shot to demonstrate this.

— Configuration Details --
Product: Eclipse 1.4.2.20120131-1457 (org.eclipse.epp.package.jee.product)
Installed Features:
org.eclipse.platform 3.7.2.v20120207-1839-9gF7UHPDFxGjd-PqDr2jX_4yKaumkoHTz04_q-q

— Configuration Details --
Product: Eclipse 1.4.2.20120131-1457 (org.eclipse.epp.package.jee.product)
Installed Features:
org.eclipse.platform 3.7.2.v20120207-1839-9gF7UHPDFxGjd-PqDr2jX_4yKaumkoHTz04_q-q
Comment 1 Jörg Thönnes CLA 2012-03-20 10:41:16 EDT 
Created attachment 212918 [details]
Screen shot showing the attachment icon
Comment 2 Steffen Pingel CLA 2012-03-20 11:00:00 EDT 
Thanks for the request. It makes sense to me and should be straight forward to implement.
Comment 3 Jörg Thönnes CLA 2012-03-20 11:33:46 EDT 
Thanks, Steffen. Looking forward to save on extra click...
Comment 4 Jörg Thönnes CLA 2012-03-20 11:34:43 EDT 
BTW, my German umlauts are broken again. With Tasktop Bugzilla this works fine.
What could be the reason?
Comment 5 Steffen Pingel CLA 2012-03-20 11:41:10 EDT 
Can you check the charset setting for Eclipse.org repository? It should be set to UTF-8.
Comment 6 Jörg Thönnes CLA 2012-03-20 11:46:50 EDT 
(In reply to comment #5)
> Can you check the charset setting for Eclipse.org repository? It should be set
> to UTF-8.

Yes, I changed it back to UTF-8 (was at ISO-8859-1 before) before I published this comment.
But for some reason this was not picked up.
Comment 7 Jörg Thönnes CLA 2012-03-20 11:50:26 EDT 
Now I restarted Eclipse -- you will see whether it helped.
Comment 8 Jörg Thönnes CLA 2012-03-20 11:51:20 EDT 
Hmmm... Obviously not. My Eclipse is using ISO-8859-1, but with Tasktop it works. No idea.
Comment 9 Jörg Thönnes CLA 2012-03-21 09:42:06 EDT 
Thanks, Steffen. This issue also appears if using the web site. Somehow the encoding is mangled from the global Eclipse account page. See bug 374895.
Comment 10 Steffen Pingel CLA 2012-05-23 06:51:33 EDT 
Frank, do you have time to look into this? The main thing to be aware of is that the icon needs to be 12x12 to fit into the toolbar.
Comment 11 Frank Becker CLA 2012-05-23 15:59:58 EDT 
Done!

If you think we need an better icon, please feel free to reopen!
Comment 12 Frank Becker CLA 2012-05-23 16:00:01 EDT 
Created attachment 216157 [details]
mylyn/context/zip
Comment 13 Steffen Pingel CLA 2012-05-23 16:47:35 EDT 
Thanks! Looks great.
Comment 14 Jörg Thönnes CLA 2012-05-24 03:03:20 EDT 
Thanks, Frank :-)