374116 – RCP apps initial window shows title "%trimmedwindow.label.eclipseSDK"

Bug 374116 - RCP apps initial window shows title "%trimmedwindow.label.eclipseSDK"

Summary: RCP apps initial window shows title "%trimmedwindow.label.eclipseSDK"

Status:	RESOLVED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	4.2
Hardware:	All All

Importance:	P1 normal (vote)
Target Milestone:	4.2 M6
Assignee:	Brian de Alwis
QA Contact:

URL:
Whiteboard:
Keywords:

Duplicates (1):	373988 (view as bug list)
Depends on:
Blocks:

Reported:	2012-03-13 13:35 EDT by Brian de Alwis
Modified:	2015-03-08 03:42 EDT (History)
CC List:	4 users (show)

See Also:	Gerrit Change Git Commit

Attachments
Strip out the %trimmedwindow.label.eclipseSDK (2.57 KB, patch) 2012-03-13 13:35 EDT, Brian de Alwis	no flags	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Brian de Alwis

2012-03-13 13:35:16 EDT

Created attachment 212579 [details]
Strip out the %trimmedwindow.label.eclipseSDK

Version: 4.2.0
Build id: I20120313-0610

The initial window for RCP apps shows a title of "%trimmedwindow.label.eclipseSDK".  The cause is a mismatch between the translated string key in the code and the plugin.properties file, which uses "trimmedwindow.label.1", done in bug 351033.

But as I pointed out in bug 372523, RCP apps don't want a string showing "Eclipse SDK 4.0" on startup anyways.

Attached patch strips out the window label and the now-useless key from the translation file.

Comment 1 Brian de Alwis

2012-03-13 13:44:06 EDT

Committed as http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=8d04316308bc6f0fd2daf03b601c5c377fe4dc5b

Comment 2 Lars Vogel

2012-03-14 04:47:17 EDT

*** Bug 373988 has been marked as a duplicate of this bug. ***

Comment 3 Torsten Witte

2015-01-30 07:37:32 EST

The LegacyIDE.e4xmi files in the org.eclipse.ui.workbench bundles of eclipse 4.3 and 4.4 contain the entry 'label="%trimmedwindow.label.eclipseSDK"' again, so the window title of my rcp app contains the text "%trimmedwindow.label.eclipseSDK".

Any ideas?

Comment 4 Eclipse Genie

2015-03-03 07:58:33 EST

New Gerrit change created: https://git.eclipse.org/r/43074

Comment 5 Simon Scholz

2015-03-03 07:59:06 EST

Thanks for pointing at this, Torsten. I just had a look at the git history and figured out that Paul has added the label again within this commit: 
http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=8f2a2860a007b7321d03dcae23bb10941a12ffea

Maybe by accident.
So I add Paul here, but also directly provide a patch for this. (https://git.eclipse.org/r/43074)

Comment 6 Paul Webster

2015-03-03 08:47:22 EST

Sorry if I added that back.  I'll push the change on Monday if no one gets to it first.

That probably got in because there are 2 of those files (the one in o.e.ui.workbench is a backup).  Can you check both?  The other should be in platform/eclipse.platform.git

PW

Comment 7 Paul Webster

2015-03-03 08:48:29 EST

(In reply to Paul Webster from comment #6)
> That probably got in because there are 2 of those files (the one in
> o.e.ui.workbench is a backup).  Can you check both? 

Actually, the second one in eclipse.platform is supposed to have the label, so that's OK

PW

Comment 8 Eclipse Genie

2015-03-08 03:42:20 EDT

Gerrit change https://git.eclipse.org/r/43074 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=81e1214db9b70523c4166e4f9072db20c2ba34ca

Comment 9 Lars Vogel

2015-03-08 03:42:32 EDT

Thanks Simon.