Community
Participate
Working Groups
Created attachment 199016 [details] Screen capture Build ID: 4.1 I20110630-1005 Scenario - Navigate to General>Keys page on Preferences dialog - Click on the dropdown arrow for the "When:" field - "In Binding View" selection label is unexternalized - This only happens in Eclipse 4.1
It's defined in the LegacyIDE.e4xmi in org.eclipse.ui.workbench and org.eclipse.platform plugins. PW
How should we externalize this string and other strings in the .e4xmi file for translation?
If you have the ModelTooling installed, bring up the context menu in the tree on the left and click "Externalize Strings". One can naturally also do that manually: a) replace string value with %mykey b) create OSGI-INF/l10n/bundle.properties and put the key-value-pair there
(In reply to comment #2) > How should we externalize this string and other strings in the .e4xmi file for > translation? Kit, it's definitely work on our part to change the strings to externalized keys and provide the .properties file. Then it can be translated. PW
M2 is done...
The externalize wizard does not check the binding context names. Not sure what I'm missing, but changing the text in the properties file didn't update the keys preference page. I thought it might be the model state being saved, but it happened even with a fresh target workspace. https://github.com/CWindatt/eclipse.platform.ui/commit/e5807a4dd9d9d3db88eeeb8bb4cb65aa2541d4ac https://github.com/CWindatt/eclipse.platform/commit/7954f46971b2e8225ca70e68ab1b5eab9e0c26a1
Same fix on Michael's github: https://github.com/mrennie/eclipse.platform.ui/commit/e5807a4dd9d9d3db88eeeb8bb4cb65aa2541d4ac and https://github.com/mrennie/eclipse.platform/commit/7954f46971b2e8225ca70e68ab1b5eab9e0c26a1
Pushed in >20120301. commit f2ccac5dc6fb91cbcea0353609784c5d16b5db8b NOTE: This is *only* the 'workbench' part of the fix...Paul, could you please check in the corresponding 'platform' part? Thanks Curtis !
Released as http://git.eclipse.org/c/platform/eclipse.platform.git/commit/?id=eef66c64193ed222ef9d7812b020ac51a12cffbc PW
Looks like both parts of the fix have been pushed. Closing as FIXED.
Created attachment 212342 [details] InBindingView Looks like it's half way fixed. In 4.2 eclipse-SDK-I20120306-2200-win32 build, a variable is now displayed, instead of the externalized string being loaded.
reopen, please investigate
(In reply to comment #8) > Pushed in >20120301. > > commit f2ccac5dc6fb91cbcea0353609784c5d16b5db8b I can't find this commit on git.eclipse.org or in the history. Paul, can you look into this? (In reply to comment #9) > Released as > http://git.eclipse.org/c/platform/eclipse.platform.git/commit/?id=eef66c64193ed222ef9d7812b020ac51a12cffbc > > PW This fix looks like it was put in fine. The names match up correctly in the properties. The fact that the string was changed, but isn't translated points to there being a bug in how we are getting the string. I'll try debugging through it.
(In reply to comment #13) > (In reply to comment #8) > > Pushed in >20120301. > > > > commit f2ccac5dc6fb91cbcea0353609784c5d16b5db8b > > I can't find this commit on git.eclipse.org or in the history. Paul, can you > look into this? I couldn't quite find it either. I've cherrypicked e5807a4dd9d9d3db88eeeb8bb4cb65aa2541d4ac and pushed that to master. Curtis, does that look correct now? PW
(In reply to comment #14) > (In reply to comment #13) > > (In reply to comment #8) > > > Pushed in >20120301. > > > > > > commit f2ccac5dc6fb91cbcea0353609784c5d16b5db8b > > > > I can't find this commit on git.eclipse.org or in the history. Paul, can you > > look into this? > > I couldn't quite find it either. I've cherrypicked > e5807a4dd9d9d3db88eeeb8bb4cb65aa2541d4ac and pushed that to master. > > Curtis, does that look correct now? > > PW Fix looks good now, thanks. I don't think the missing change was the cause of the mismatch, still investigating.
I am using the same build on linux and not seeing the issue.
This turned out to be an interesting bug. Unlike extension registry, labels in the model have to be explicitly translated. The labels for command contexts weren't translated. The reason only one of them was showing up non-translated is that it was the only one specific to e4. For the rest of command contexts, their names were overwritten by ContextToModelProcessor.generateContexts() and used extension-registry-translated names from 3.x command contexts. I added code to perform localization to ContextProcessingAddon: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=21fd001ce9dd1ea4da8adf6810526ba45624c172
Verified in I20120430-1800.
