Bug 367784 - user login status popup should not replace user menu
Summary: user login status popup should not replace user menu
Status: RESOLVED FIXED
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: Client (show other bugs)
Version: 0.3   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.4 RC1   Edit
Assignee: Malgorzata Janczarska CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 368870
  Show dependency tree
 
Reported: 2012-01-03 13:09 EST by Susan McCourt CLA
Modified: 2012-02-09 11:50 EST (History)
7 users (show)

See Also:
malgorzata.tomczyk: review? (susan)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Susan McCourt CLA 2012-01-03 13:09:29 EST
I never really noticed until now that the user login "menu" was replaced by the login popup dialog.  I use that login popup all the time, and find it quite good/appears when I need it, disappears when I'm done.  But I guess I never quite realized that it completely replaced the old menu, because I never use the profile page, etc.

I would expect that the the "login status" would be one of several actions in a user menu, including also "profile" and I suspect in the future "preferences" etc.  I realized this when I suggested putting "tasks" in the user menu for now (bug 367442) and it showed up in the popup, which is not what I was expecting.  

If you look at other sites that use the username/menu concept, they typically offer links to the profile, settings, logout, etc. from the menu.  For example, facebook, netflix, etc.

Some sites use the username as a link to the profile (amazon, github) and then have top level buttons for the other things.

Jazz uses a rich menu that has links for the menu items.

Perhaps you could say that our popup is more like the jazz approach, but it doesn't feel right:
- it doesn't drop down like a menu (uses the bubbly tooltip dialog).  This is I think what feels weird.
- the layout is not vertical, I have to read columns of text to figure out what I can do here
- the bolding of the plug-in name is emphasizing the wrong thing.

I don't think the user cares what plugin is contributing to that popup anyway.

Suggestion:

- if we need to group login statuses in one place, we can have a "login status" popup that is invoked from a user menu
- "profile" should have its own link in the menu
- "operations" (temporary) should be a menu item
- "preferences" will likely show up here when the preference work by Anton gets released

We are reexamining the header and what goes where for M2, but independently of the styling or placement of the menu, I think that it would be better to have individual items listed in menu-fashion rather than the current tooltip dialog.

Many sites are moving away from the username/menu thin
- facebook, amazon, 

- github got rid of the whole user menu concept in the skinny header, but notice they have different buttons for alerts,
Comment 1 Susan McCourt CLA 2012-01-21 20:11:49 EST
the temporary "operations" thing is now in the footer.

So I suggest the following:

Username <twistie>
-----------
Profile
Settings
Sign Out
Help

- I think the login status that shows in the hover today (what plugin you are logged into and since when) has always been an implementation detail that doesn't deserve such an "up front" place.  What if we put it in a "login status" pane on the profile page?  

- I think that help could be moved from a main link to this menu 

- People are used to looking for settings in a user menu, so I don't see that they need to have their own visible link in the primary nav.

cc'ing others for opinion.
If no one disagrees I can do this as part of all the common header/footer cleanup (but may need Gosia's help to move the status stuff to the profile page)
Comment 2 Susan McCourt CLA 2012-01-21 23:26:18 EST
(In reply to comment #1)

> If no one disagrees I can do this as part of all the common header/footer
> cleanup (but may need Gosia's help to move the status stuff to the profile
> page)

actually the "logged in since" is already there, so it's just putting the list of authenticated plugins on the profile somewhere.
Comment 3 Szymon Brandys CLA 2012-01-23 05:16:05 EST
(In reply to comment #0)
> Some sites use the username as a link to the profile (amazon, github) and then
> have top level buttons for the other things.

> I don't think the user cares what plugin is contributing to that popup anyway.

The info in the header is not what plug-in contributes to the popup, but what server we are logged in to.
If you have multiple filesystems plugged in to Orion, you will see something like this:

Server1 [Profile][Sign Out]
	x logged in since ...
Server2 [Profile][Sign Out]
	y logged in since ...

Most of the time we have only one auth plugin registered. Then I would expect to see:
AUser [v]
			|_ Preferences
			|_ Operations
			|_ Sign Out
			|_ Help
			
Clicking on "AUser" would open the profile page.

For many auth plug-in registered, I would like to see:
Profiles [v]
			|_ Preferences
			|_ Operations
			|_ Help

Clicking on "Profiles" would open a popup or a page that allows to visit profiles and sign out from servers. 

Alerts like "Need to log in to something" would have a separate presentation. Maybe still a popup but different than the one for managing profiles.
It would just ask to login to some server, not show a list of all registered auth plug-ins.
Comment 4 Susan McCourt CLA 2012-01-23 12:03:12 EST
minor point is we don't need "Operations" because it's in the footer now.
I named it "Server Operations" but if you prefer a better name it's easy to change.  I felt like "Operations" was not obvious to a newbie what it might mean.

Maybe "Background Operations"?
Comment 5 Susan McCourt CLA 2012-01-24 11:16:22 EST
marking M2 as I hope to resolve where "operations" and "settings" go as part of the header/footer.  It may slip to the RC's though.
Comment 6 Susan McCourt CLA 2012-02-02 13:51:37 EST
see also bug 349602
Comment 7 Malgorzata Janczarska CLA 2012-02-06 08:45:12 EST
Susan, if you are very busy (and I think you are) than I can take it over from you.
Comment 8 Susan McCourt CLA 2012-02-06 13:50:38 EST
(In reply to comment #7)
> Susan, if you are very busy (and I think you are) than I can take it over from
> you.

THANKS, Gosia!
Yes, please do.

There are a few help menu items I'd like to see here as part of bug 349602 (but I kept that bug because it also involves general keybinding checking).

I imagine something like this:

User [V]
   Settings  (link to settings page)
   Operations
   Sign out
   --------------------- (separator)
   Help->  Documentation  (the link fr)
           Keyboard Help  (the key assist panel command)
           About Orion  (href to the about.html)

It sounds like you and Szymon know what to do re: Profiles.  I was thinking profile was in the menu but I guess it's the difference between clicking "User" and clicking "menu".  Does not matter to me.  Note that if we are going to use an empty menu rather than the user name being the label for the menu, we have to ensure there is some accessible explanatory text on the menu itself.   Please see bug 368870 (which I've just assigned to you.)


Then remove from the banner (now in commonHTMLFragments.js)
- help icon

Remove from footer
- Server Operations

In org.eclipse.orion.client.core/web/plugins/pageLinksPlugin.html
- remove the "settings link"
Comment 9 Malgorzata Janczarska CLA 2012-02-09 07:49:35 EST
(In reply to comment #8)
> About Orion  (href to the about.html)
This is one thing I don't know, where is the about.html page? I know we have an Orion page on wiki is this what you mean?
Comment 10 Malgorzata Janczarska CLA 2012-02-09 08:45:05 EST
I pushed most of the changes, Susan, how do you like it now? If it's ok now adding the link to about.html (when I know what it is) will be the last thing to do here.
Comment 11 Susan McCourt CLA 2012-02-09 11:02:51 EST
Hi, this looks great.
The about link is
http://orion.eclipse.org/help/about.html

In playing with it, I have one more request (sorry!)  
Grouping the help items doesn't play well, does it?  You get that right arrow but of course the whole menu is on the right so you end up getting the submenu on the left.  I didn't think about that ahead of time.

So could we flatten that group and just have

------------  (separator)
Help (which is the thing I previously called "Documentation")
Keyboard Help
About Orion

Thanks again.

I will worry about the hover (and possibly changing the dropdown icon) as part of my ongoing work with styling....
Comment 12 Ken Walker CLA 2012-02-09 11:15:33 EST
Just trying this, when I go to the settings page, the triangle beside the username doesn't seem to be there?
Comment 13 Malgorzata Janczarska CLA 2012-02-09 11:21:41 EST
(In reply to comment #12)
> Just trying this, when I go to the settings page, the triangle beside the
> username doesn't seem to be there?
I noticed it as well, this is only at the settings page. Maybe there's some css missing or overriding there?
Comment 14 Susan McCourt CLA 2012-02-09 11:31:29 EST
(In reply to comment #13)
> (In reply to comment #12)
> > Just trying this, when I go to the settings page, the triangle beside the
> > username doesn't seem to be there?
> I noticed it as well, this is only at the settings page. Maybe there's some css
> missing or overriding there?

I opened bug 371104.
I seem to recall a dojo override of the menu background for the settings page.  This should be qualified so that the override is not pervasive.
Comment 15 Malgorzata Janczarska CLA 2012-02-09 11:50:42 EST
OK, changes from comment #11 are applied, so I suppose this is all what's to do on this bug.