Bug 349602 - [client] common keybindings for explorer actions
Summary: [client] common keybindings for explorer actions
Status: RESOLVED FIXED
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: Client (show other bugs)
Version: 0.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.5 M2   Edit
Assignee: Susan McCourt CLA
QA Contact:
URL:
Whiteboard:
Keywords: accessibility, usability
Depends on: 372652
Blocks: 365361
  Show dependency tree
 
Reported: 2011-06-16 13:42 EDT by Susan McCourt CLA
Modified: 2012-05-21 15:28 EDT (History)
6 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Susan McCourt CLA 2011-06-16 13:42:37 EDT
When we start working on accessibility of Orion, we will need keybindings for all commands.  The issues I see:

- ensure there are no keybinding conflicts in Orion
- ensure we don't conflict with the most common browser bindings (specifically those used consistently across all browsers)
- revisit all our command names since they will show up in the key assist dialog.  (Those that are only shown by icon may not have good names)
- ensure all commands have tooltips.  It would be nice to show the tooltips in the keyassist dialog as a further description of the command
- for command links and icons, we have no visual indicating what the keybinding would be.  This has to be discoverable by a keyboard only user.  What are the accessibility requirements here?  Maybe if we have a plainly shown cue in the UI that shows the binding for the keyassist dialog itself, then the user could discover the rest.
Comment 1 Carolyn MacLeod CLA 2011-09-23 12:17:38 EDT
> This has to be discoverable by a keyboard only user.
> What are the accessibility requirements here?

Are you considering having a "Show Keybinding List" command like the one in Eclipse? (i.e. Ctrl+Shift+L). If so, then this will probably satisfy all discoverability requirements/needs.
Comment 2 Susan McCourt CLA 2011-09-23 14:47:33 EDT
(In reply to comment #1)
> > This has to be discoverable by a keyboard only user.
> > What are the accessibility requirements here?
> 
> Are you considering having a "Show Keybinding List" command like the one in
> Eclipse? (i.e. Ctrl+Shift+L). If so, then this will probably satisfy all
> discoverability requirements/needs.

yes, we have one currently.
Ctrl+Shift+L in the editor, and Shift+? everywhere else.
What I was wondering is whether we have to surface this binding or a link to the dialog in the UI so that someone could learn it.  Or is it enough just to doc it and people learn it.  (Because every other keystroke can be learned from this dialog, but how do you know how to open the dialog via the keyboard)
Comment 3 Carolyn MacLeod CLA 2011-09-23 15:16:10 EDT
Good question. It's in the Help menu in Eclipse, i.e.
Help -> Key Assist... (Ctrl+Shift+L)
Can you contribute to the browser's help menu? (I don't have a clue... <g>).
Or is there another place where it makes sense to place "actions" like help?

If there's no good (and correct/intuitive) place to surface the binding, then let me know, and I will find out if doc is good enough in this case. (It probably isn't, but I can find out for sure).
Comment 4 Susan McCourt CLA 2012-02-02 13:50:41 EST
for RC2 let's minimally ensure that "keyboard help" appears in a menu somewhere.

I think we should put help in the user menu and perhaps have

Help->  Documentation
        Keyboard Help
        About Orion
Comment 5 Susan McCourt CLA 2012-02-07 10:29:43 EST
This is more appropriate for 0.5.  Let's focus on bug 366445 (getting what we already have as consistent) before we try this.  We also now have tabbability to all commands so there is keyboard access for all of them.
Comment 6 Carolyn MacLeod CLA 2012-02-10 23:53:48 EST
> - ensure we don't conflict with the most common browser bindings
> (specifically those used consistently across all browsers)

You have probably seen this table, but just in case:
http://dmcritchie.mvps.org/firefox/keyboard.htm
Also, this table:
http://en.wikipedia.org/wiki/Table_of_keyboard_shortcuts
Comment 7 Susan McCourt CLA 2012-02-15 15:00:20 EST
John suggests we start with some of the well known key shortcuts:

Del for delete and F2 for rename
Comment 8 Susan McCourt CLA 2012-05-21 15:28:38 EDT
Renamed bug to show that we are focusing on getting the most common/expected keybindings implemented.

Delete has been the most popular one mentioned.  I also implemented Rename (F2).  We can implement more of these as needed in new bugs.  Fixed in http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=0406ac5fe71677f544ffb8673973bd20355b9237