Community
Participate
Working Groups
While using a screen reader, there appears to be an extra unlabeled button between the user button and the help button at the top right of the screen. This button doesn't appear to do anything, and is likely to confuse the user.
I have fixed this bug in the following repository in the accessibility branch. https://github.com/max-li/orion.client.git
(In reply to comment #1) > I have fixed this bug in the following repository in the accessibility branch. > https://github.com/max-li/orion.client.git okay, I suspect you mean https://github.com/max-li/orion.client that said, it is better if you paste the link to the commit. For example https://github.com/max-li/orion.client/commit/43cf5f127804ef34b43f5ad41c1050cedca7cb37 (note that this is unrelated commit. I was not able to find the correct one)
Sorry Max, I was not in the correct branch. This is the commit https://github.com/max-li/orion.client/commit/bc69df820c0794f0cc0d5818597329ee7be8dd44 Susan, I suppose you own globalCommands, do you want to text/include this fix ? Adding our accessibility expert, Car, to the CC list too.
> Susan, I suppose you own globalCommands, do you want to text/include this fix ? Susan, let me know if you are too busy, I can release the changes too.
(In reply to comment #4) > > Susan, I suppose you own globalCommands, do you want to text/include this fix ? > > Susan, let me know if you are too busy, I can release the changes too. this change may not be needed depending on the outcome of bug 367784. I think we are going to bring the user menu back. If we decide not to use a menu, then I would suggest that we not create one at all and use a different DOM element (like a button).
It seems that dojo Drop Down Button contains an extra input which is usually hidden but your screenreader sees it as an extra button. This input is used to hold a value of the button that may be needed if we use the button as a part of the form. But is this situation the button is just for navigation and removing this node doesn't influence the behavior of the button. I pushed your change (added a check if valueNode exists), so this issue should be fixed, but please note that there where plenty changes in this area (bug 367784) and they need accessibility testing. In the new version the Drop Down Button doesn't have any label, but it has an "alt" and "title" so it should be read correctly by screenreaders. Please mark this bug as fixed when you verify that the change pushed fixed the problem.
(In reply to comment #6) > Please mark this bug as fixed when you verify that the change pushed fixed the > problem. I have verified that the bug is now fixed.
