Bug 36418 - [Markers] Please make extension point org.eclipse.ui.markerImageProviders public
Summary: [Markers] Please make extension point org.eclipse.ui.markerImageProviders public
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: IDE (show other bugs)
Version: 2.0.2   Edit
Hardware: All All
: P3 enhancement with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
: 37741 69894 (view as bug list)
Depends on: 260909
Blocks: 308608 58895
  Show dependency tree
 
Reported: 2003-04-11 14:44 EDT by Kim Horne CLA
Modified: 2019-11-14 02:19 EST (History)
6 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kim Horne CLA 2003-04-11 14:44:54 EDT
This would be an extremely useful feature to be made available (for me, at least
;)).  I'm working on a visual editor that has it's own problem marker types that
are displayed in a standard java editor.  Right now they look like any other
java problem.  It would be nice if I could provide my own images to distinguish
between the two problem types.
Comment 1 Nick Edgar CLA 2004-02-26 22:36:01 EST
If this were to be made API, some problems with it would need to be addressed.
For example, items in the registry are currently ordered by declaring plugin id 
then by order of extension within that plugin, and the search for a marker 
image provider that matches the given marker's type is done in this order.

This can make it appear not to work in some simple scenarios.
For example:
- plugin zzz defines marker type zzzMarker which is a subtype of core's Task 
marker type
- plugin zzz also defines a markerImageProvider extension point that associates 
zzzMarker markers with an image

In this scenario, the image returned will be the regular task marker image 
because org.eclipse.ui, which defines the markerImageProvider for Tasks, comes 
before zzz.

I see two possible approaches:
(1) find the marker image provider that most closely matches the given marker's 
type (i.e. fewest steps in the supertype chain)
(2) introduce some other ordering criteria, e.g. markerImageProvider extension 
id

(1) will require new core API to expose the marker type hierarchy
(2) is also arbitrary, but gives the plugin developer more control since the id 
of the markerImageProvider need not prefixed by the containing plugin's id.

Comment 2 Nick Edgar CLA 2004-02-26 22:36:42 EST
Note that the markerImageProvider extension point has moved to 
org.eclipse.ui.ide in 3.0.
Comment 3 Nick Edgar CLA 2006-03-15 13:47:11 EST
This may have already been done.  Not sure if it's exposed as API now.
Comment 4 Tod Creasey CLA 2006-04-07 10:19:34 EDT
*** Bug 37741 has been marked as a duplicate of this bug. ***
Comment 5 Tod Creasey CLA 2006-04-12 13:59:25 EDT
*** Bug 69894 has been marked as a duplicate of this bug. ***
Comment 6 Mirko Raner CLA 2007-06-01 13:18:50 EDT
Uh, I just came across this by chance... I'm not sure I understand this issue correctly, but the markerImageProviders extension point is public since 2.1: http://help.eclipse.org/help32/index.jsp?topic=/org.eclipse.platform.doc.isv/reference/extension-points/org_eclipse_ui_ide_markerImageProviders.html

How well it works in practice may be another issue here, but as far as the extension point itself is concerned it seems to me that this bug can be closed.
Comment 7 Tod Creasey CLA 2007-06-01 13:57:03 EDT
IMarkerImageProvider is still internal
Comment 8 Susan McCourt CLA 2009-07-15 12:16:05 EDT
"As per http://wiki.eclipse.org/Platform_UI/Bug_Triage_Change_2009"
Comment 9 Hitesh CLA 2010-04-07 06:27:42 EDT
See also :Bug 260909, Bug 26029
Comment 10 Dani Megert CLA 2010-04-09 03:34:26 EDT
>IMarkerImageProvider is still internal
And the extension point doc says at the bottom:
  "markerImageProvider is currently internal and should not be considered API. "


JDT would like to use that extension point (see bug 308608).

Boris, can we target this for 3.7?
Comment 11 Lars Vogel CLA 2019-11-14 02:19:44 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

If the bug is still relevant, please remove the "stalebug" whiteboard tag.