Community
Participate
Working Groups
I want to use a ResourceListSelectionDialog bit have it open with the initial filter (pattern) of "*.e". The filter/pattern can't be passed as parameter to the constructor or as API. Subclasses can't get to the field either. Please provide API or make the field protected so that subclasses can set it from their constructors.
I agree with Marcio that this would be a really useful feature to have, and it is so easy to provide. Just add a new constructor, and possibly a new 'setter' method as well. Please add the functionality to the ResourceListSelectionDialog directly. This isn't the kind of thing that you want plugin developers to add with a subclass. Subclassing is brittle, it is always possible for the implementors of ResourceListSelectionDialog to make a change that will break how some lowly plugin developer embellished it.
We likely will not have time to do this ourselves for 3.0. However if you have a suggested patch feel free to attach it.
Reopening now that 3.0 has shipped
I have just stolen ResourceListSelectionDialog with remarkable ease to create a selection for EMF elements within an EMF ResourceSet. But I had to copy all the code. There seems to be a much more general functionality here to select from a hierarchy of objects that have labels. So if use of IResource/IContainer is generalised to Object serviced by a ContentProvider, externally settable LabelProvider, and a Filter rather than an int typeMask, I could have used it unchanged.
investigate during M5 as part of the refactoring going on in bug 94382.
sorry, this is being punted from my 3.2 plan in favor of other more pressing issues.
Created attachment 34789 [details] This is a patch that should resolve he problem Tested on 3.2M4. Should be valid for the HEAD branch because class ResourceListSelectionDialog has not been changed quite a while.
Thanks for the patch. I'm marking this bug M6 as a reminder to take a look.
Not sure what I was thinking when I moved this back to M6, since M5 was API freeze. Any exceptions must be PMC approved, so this one won't be looked at unless priority is raised.
moving Open Resource related bugs to Szymon. Szymon, please move between you and Krystof as needed. Let me know if you have any questions. These are all the bugs I had related to OpenResource.
Done, fixed for M6.
Fixed in 3.3 M6
This is no longer fixed for Eclipse 4.2. The ResourceListSelectionDialog again lacks the possibility to set an initial Pattern.
(In reply to comment #13) > This is no longer fixed for Eclipse 4.2. The ResourceListSelectionDialog > again lacks the possibility to set an initial Pattern. I went back through our releases, and although this bug is marked as fixed I cannot find this API actually added. Unless they mean that because FilteredResourcesSelectionDialog replaces ResourceListSelectionDialog this API is now available. PW
