Bug 94382 - [Dialogs] Open resource dialog should look like the open type dialog
Summary: [Dialogs] Open resource dialog should look like the open type dialog
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.1   Edit
Hardware: PC Linux-GTK
: P4 enhancement (vote)
Target Milestone: 3.3 M2   Edit
Assignee: Szymon Brandys CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 91227 94443 (view as bug list)
Depends on:
Blocks: 30018 90170 93162
  Show dependency tree
 
Reported: 2005-05-10 11:41 EDT by Billy Biggs CLA
Modified: 2010-12-15 17:32 EST (History)
9 users (show)

See Also:


Attachments
New AbstractSearchDialog and ResourceSearchDialog patch (91.06 KB, patch)
2006-09-07 09:07 EDT, Szymon Brandys CLA
no flags Details | Diff
Fixes according to Tod comments (36.26 KB, patch)
2006-09-07 09:13 EDT, Szymon Brandys CLA
no flags Details | Diff
Fixes according to Tod comments (36.26 KB, patch)
2006-09-07 09:44 EDT, Szymon Brandys CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Billy Biggs CLA 2005-05-10 11:41:06 EDT
I20050510-0010

The new open java type dialog has a significantly different user interface than
the open resource dialog.  The open resource dialog should probably be updated
to behave the same.
Comment 1 Billy Biggs CLA 2005-05-10 13:49:52 EDT
*** Bug 94443 has been marked as a duplicate of this bug. ***
Comment 2 Susan McCourt CLA 2005-09-07 17:51:08 EDT
Info from Nick:
In the UI summit call, the suggested approach to making Open Resource be 
consistent with Open Type was:
- look at the Open Type implementation in JDT
- push down parts of it that are generally useful (e.g. dialog structure, 
background population, camel-casing)
- implement Open Resource in terms of this
- make it so that JDT can migrate Open Type to this framework, time-permitting 
(needs to be easy for them)

Comment 3 Susan McCourt CLA 2005-09-07 17:58:10 EDT
I will look at this for 3.2 M3.
Comment 4 Eugene Kuleshov CLA 2005-09-07 23:07:53 EDT
By the way. it would be nice to get rid of those annoying modal progress dialogs
duting this integration. There are at least two cases when they appear - initial
indexing and index verification (generally after any switch from and back to
Eclipse). Second one appears for about 10 seconds and it is definetely too long
intervention.
Comment 5 Dirk Baeumer CLA 2005-09-08 05:20:18 EDT
Eugene,

this can't be done in the general framework since it is specific for JDT. Major
improvements have already be done for 3.1.1 and 3.2 M1. Verifications beside the
first one which can't be avoided are only done when types are removed. So this
occurrs far less. Another optimization is to do the verification in background.
I have the code ready and it will go into M3. Needs some testing first since its
not trivial ;-).
Comment 6 Eugene Kuleshov CLA 2005-09-08 07:13:44 EDT
Dirk, actually that is what I meant. Please move this stuff to the background
and show progess in a Open Type dialog itself (similar to search progress)
Comment 7 Michael Van Meekeren CLA 2005-09-08 09:57:33 EDT
Adding TC for comment on jobs+background progress reporting inlined in the dialog.
Comment 8 Dirk Baeumer CLA 2005-09-08 12:18:15 EDT
Tod, the open type dialog has support for showing embedded background job
progress. See ProgressUpdateJob in TypeInfoViewer. 
Comment 9 Susan McCourt CLA 2005-10-20 16:19:33 EDT
Moving to M4, still working on some other items for M3.
Comment 10 Susan McCourt CLA 2005-11-17 13:14:01 EST
note to self: see discussion in bug #93162
Comment 11 Dirk Baeumer CLA 2005-11-24 11:03:55 EST
Susan, have you started any work here. I am working on a second instance of the open type dialog and might be able to provide some abstractions. 
Comment 12 Susan McCourt CLA 2005-11-27 14:53:56 EST
No, I've not started, but plan to do so this week, hopefully by Tuesday.  So please keep me posted on what's happening and I'll annotate this bug when I start.
Comment 13 Susan McCourt CLA 2005-12-05 16:24:17 EST
Moving milestone to M5.
I have been looking at this on and off, but won't get it finished in time.  
There are two parts to this:
1.  Factoring out the behavior for filtering, history, etc.  (Dirk has already completed a good first pass at this and I've got a prototype that's been brought into Platform UI).  It will likely appear as an advanced JFace viewer.
2.  Adapting ResourceSelectionDialog to use this viewer, and adding other features such as CamelCase, etc.
Comment 14 Susan McCourt CLA 2006-02-02 13:45:57 EST
Sorry, this is being punted from my 3.2 plan in favor of more pressing issues.  If this bug gets reassigned to someone else, contact me for some old experiments/code from my M4 work.  

I know this is a much-requested feature, it just doesn't make the cut given everything else on my plate.
Comment 15 Susan McCourt CLA 2006-07-10 17:25:43 EDT
moving Open Resource related bugs to Szymon.
Szymon, please move between you and Krystof as needed.  Let me know if you have any questions.  These are all the bugs I had related to OpenResource.
Comment 16 Tod Creasey CLA 2006-09-06 10:19:03 EDT
An initial pass at the API has been released.

Szymon and Kryzstof - please mark the new API as experimental as we still might need to make some changes in 3.3.
Comment 17 Szymon Brandys CLA 2006-09-07 09:07:49 EDT
Created attachment 49607 [details]
New AbstractSearchDialog and ResourceSearchDialog patch

AbstractSearchDialog is a new abstract class which should be used as super class for resource and type search dialogs.
Comment 18 Szymon Brandys CLA 2006-09-07 09:13:24 EDT
Created attachment 49608 [details]
Fixes according to Tod comments

- EXPERIMENTAL taf
- doubleclick selection
- shows details field by default
Comment 19 Szymon Brandys CLA 2006-09-07 09:44:12 EDT
Created attachment 49613 [details]
Fixes according to Tod comments
Comment 20 Tod Creasey CLA 2006-09-11 10:59:51 EDT
Patch released.
Comment 21 Szymon Brandys CLA 2006-09-12 10:03:59 EDT
Fixed
Comment 22 Susan McCourt CLA 2010-12-15 17:32:35 EST
*** Bug 91227 has been marked as a duplicate of this bug. ***