Bug 355819 - [gtk] [rh6] [ubuntu 11.04] [menu] missing icons in menus
Summary: [gtk] [rh6] [ubuntu 11.04] [menu] missing icons in menus
Status: RESOLVED WORKSFORME
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 3.7   Edit
Hardware: PC Linux
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Platform-SWT-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2011-08-25 07:19 EDT by Helmut J. Haigermoser CLA
Modified: 2018-04-11 11:59 EDT (History)
8 users (show)

See Also:


Attachments
Shows my Ubuntu Eclipse 3.7, without icons in menus (86.85 KB, image/png)
2011-08-25 07:20 EDT, Helmut J. Haigermoser CLA
no flags Details
Screen shot showing the "Window->Show View" sub menu, without icons (140.15 KB, image/png)
2011-08-25 07:24 EDT, Helmut J. Haigermoser CLA
no flags Details
Ubuntu itself does not show menu icons either, but it does show start menus correctly (137.74 KB, image/png)
2011-08-25 08:37 EDT, Helmut J. Haigermoser CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Helmut J. Haigermoser CLA 2011-08-25 07:19:09 EDT
Build Identifier: 3.7

On newer Linuxes, like Ubuntu 11.04 and RedHat 6.1, the menus in Eclipse do lack an icon to the left, see attached screen shot.

Reproducible: Always

Steps to Reproduce:
1.Fire up Eclipse 3.7 on Ubuntu 11.04 or RedHat Workstation 6.1
2.Window->Show View for example will bring up a menu with views, but without icons
Comment 1 Helmut J. Haigermoser CLA 2011-08-25 07:19:51 EDT
CQ:WIND00295762

*changing release to 3.7*
Comment 2 Helmut J. Haigermoser CLA 2011-08-25 07:20:26 EDT
Created attachment 202140 [details]
Shows my Ubuntu Eclipse 3.7, without icons in menus
Comment 3 Helmut J. Haigermoser CLA 2011-08-25 07:24:21 EDT
Created attachment 202141 [details]
Screen shot showing the "Window->Show View" sub menu, without icons
Comment 4 Remy Suen CLA 2011-08-25 07:56:26 EDT
Sounds like a duplicate of bug 293720.
Comment 5 Helmut J. Haigermoser CLA 2011-08-25 08:34:50 EDT
(In reply to comment #4)
> Sounds like a duplicate of bug 293720.

I can confirm that the suggested workaround in 293720 does the trick of bringing back the menu icons, so this probably is a duplicate! :)

Watch my next attachment for some additional findings...

Helmut
Comment 6 Helmut J. Haigermoser CLA 2011-08-25 08:37:15 EDT
Created attachment 202145 [details]
Ubuntu itself does not show menu icons either, but it does show start menus correctly

One more thing, the "no menu icons" setting seems not to affect start menus inside these menus, our "Show View" menu on the other hand does not show even the "start menu icons" for views to be launched...
Comment 7 Helmut J. Haigermoser CLA 2011-08-25 08:39:39 EDT
(In reply to comment #6)
> Created attachment 202145 [details]
> Ubuntu itself does not show menu icons either, but it does show start menus
> correctly
> 
> One more thing, the "no menu icons" setting seems not to affect start menus
> inside these menus, our "Show View" menu on the other hand does not show even
> the "start menu icons" for views to be launched...

Just realized that was not as clear as could be:

Ubuntu: 
- Menu "Preferences" has no icon: correct
- Entry "About Me" has an icon though

Eclipse:
- Menu "Show View" has no icon: correct
- Entry "Ant" has no icon either: problem

Let me know what you think! :)
Helmut
Comment 8 Martin Oberhuber CLA 2011-09-07 07:49:30 EDT
(In reply to comment #6)

So... the workaround from bug 293720 comment 12 fixes "some" menu icons but not all of them? Or have I been misunderstanding?

I'm also not quite clear now whether this is a dup of bug 293720 or not.

When other apps (eg native Ubuntu apps) do have menu icons but Eclipse does not, this seems like a pretty major usability issue to me. At the minimum I'd expect the workaround from bug 293720 to be published in release notes, but maybe more needs to be done?
Comment 9 Arun Thondapu CLA 2011-09-20 07:37:55 EDT
(In reply to comment #8)
> So... the workaround from bug 293720 comment 12 fixes "some" menu icons but not
> all of them? Or have I been misunderstanding?

The workaround does fix all the Eclipse menu icons, I have faced this problem and used the same workaround myself too.

> I'm also not quite clear now whether this is a dup of bug 293720 or not.

This is indeed a duplicate, the problem is the same and the fix/workaround is the same.

> When other apps (eg native Ubuntu apps) do have menu icons but Eclipse does
> not, this seems like a pretty major usability issue to me. At the minimum I'd
> expect the workaround from bug 293720 to be published in release notes, but
> maybe more needs to be done?

This seems more like an obscure desktop setting change rather than an Eclipse bug to me. However, I'll see if there is something we can do in SWT to ensure the menu icons are always displayed irrespective of the desktop setting, like in the case of some of the native apps.
Comment 10 Sergey Prigogin CLA 2015-05-28 21:03:54 EDT
(In reply to Arun Thondapu from comment #9)

Menu icons are not shown for me in KDE despite being enabled in KDE preferences. The workaround described in comment #12 does not make any difference.
Comment 11 Sergey Prigogin CLA 2015-05-28 21:12:34 EDT
Native applications, e.g. Dolphin, Kate, gedit do show icons in menus.
Comment 12 Alexander Kurtakov CLA 2015-11-24 10:03:32 EST
Hi Sergey, 
This should be fixed for GTK 3.x in master now through but 470298 . Fixing it for GTK 2.x is out of scope now as it was hard enough to get it right for GTK 3 only and SWT itself defaults to GTK 3 when available. 
Please test with latest nightly or I-build and once you verify it we can close as duplicate.
Comment 13 Eric Williams CLA 2018-04-11 11:59:19 EDT
(In reply to Alexander Kurtakov from comment #12)
> Hi Sergey, 
> This should be fixed for GTK 3.x in master now through but 470298 . Fixing
> it for GTK 2.x is out of scope now as it was hard enough to get it right for
> GTK 3 only and SWT itself defaults to GTK 3 when available. 
> Please test with latest nightly or I-build and once you verify it we can
> close as duplicate.

Closing, since there was no response in awhile.