Bug 293720 - [GTK2.18] Menu icons missing
Summary: [GTK2.18] Menu icons missing
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 3.5.1   Edit
Hardware: PC Linux
: P3 normal with 3 votes (vote)
Target Milestone: ---   Edit
Assignee: Bogdan Gheorghe CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 294905 313253 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-10-29 14:51 EDT by Andrew Overholt CLA
Modified: 2015-08-31 13:31 EDT (History)
13 users (show)

See Also:


Attachments
GTK 2.16 (44.96 KB, image/png)
2009-10-29 14:52 EDT, Andrew Overholt CLA
no flags Details
gtk 2.18 (38.44 KB, image/png)
2009-10-29 14:53 EDT, Andrew Overholt CLA
no flags Details
Appearance-Preferences.png (30.54 KB, image/png)
2009-11-02 15:03 EST, Benjamin Drung CLA
no flags Details
gconf-editor change to enable icons in menus (68.37 KB, image/png)
2010-05-02 12:51 EDT, Craig Setera CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Overholt CLA 2009-10-29 14:51:40 EDT
Menu icons are missing when running 3.5.1 under GTK+ 2.18.  They work fine with 2.16.  I'll attach two screenshots to show the difference.
Comment 1 Andrew Overholt CLA 2009-10-29 14:52:31 EDT
Created attachment 150864 [details]
GTK 2.16

Screenshot showing icons with GTK 2.16.
Comment 2 Andrew Overholt CLA 2009-10-29 14:53:02 EDT
Created attachment 150865 [details]
gtk 2.18

Screenshot showing missing icons with GTK 2.18.
Comment 3 Andrew Overholt CLA 2009-10-29 15:18:40 EDT
This is happening for me with gtk2-2.18.3 on Fedora 12 but not on 2.18.0 on Ubuntu (9.04 with some 9.10 packages).
Comment 4 Andrew Overholt CLA 2009-10-29 15:19:17 EDT
Alex, any changes between 2.18.0 and 2.18.3 that ring a bell for you?
Comment 5 Benjamin Drung CLA 2009-11-01 09:41:41 EST
That's a new "feature" of GNOME 2.28. Please open gnome-appearance-properties, select the Interface tab and enable "Show icons in menus".

Corresponding Ubuntu bug: https://launchpad.net/bugs/464893
Comment 6 Andrew Overholt CLA 2009-11-02 09:20:43 EST
(In reply to comment #5)
> That's a new "feature" of GNOME 2.28. Please open gnome-appearance-properties,
> select the Interface tab and enable "Show icons in menus".

Thanks for pointing this out.  I don't have an "Interface" tab in my gnome-appearance-properties.  My gnome-appearance-properties comes from:

control-center-2.28.1-4

Is there perhaps an Ubuntu-specific patch to this?

Regardless of this GNOME change, is there something SWT-side that should be done?
Comment 7 Benjamin Drung CLA 2009-11-02 15:03:42 EST
Created attachment 151111 [details]
Appearance-Preferences.png

In Ubuntu gnome-control-center provides gnome-appearance-properties. I have version 2.28.1-0ubuntu1 installed (screenshot attached).

There is no obvious patch for adding the "Interface" tab. You can grab the source from https://launchpad.net/ubuntu/+source/gnome-control-center/1:2.28.1-0ubuntu1 and have a look at it.

I think this is GNOME only change and there is nothing to do on the SWT-side. So you can close this bug.
Comment 9 Bogdan Gheorghe CLA 2009-11-16 22:46:16 EST
*** Bug 294905 has been marked as a duplicate of this bug. ***
Comment 10 Craig Setera CLA 2010-05-02 12:51:04 EDT
Created attachment 166736 [details]
gconf-editor change to enable icons in menus

With Ubuntu Lucid (and presumably other distributions and versions), the menu icons can still be enabled by using "gconf-editor".  I launched it from command line, but it may also be available somewhere via system menus.
Comment 11 Alekseev V. CLA 2010-07-22 09:47:13 EDT
(In reply to comment #10)
> Created an attachment (id=166736) [details]
> gconf-editor change to enable icons in menus
> 
> With Ubuntu Lucid (and presumably other distributions and versions), the menu
> icons can still be enabled by using "gconf-editor".  I launched it from command
> line, but it may also be available somewhere via system menus.

Yes, that is thew solution, but, any way, it will be much better if it will be some eclipse-provided solution to keep the icons. They are major thing in usability, and missing them is a real problem for user (for me do), so it is no good to depend in such things from GTK developers (the use to do strange things). 

In general it is not good idea to use diferent interfaces with diferent concepts, may be it will be useful to replace GTK menus with own ones.
Comment 12 Marcin Lewandowski CLA 2010-11-13 06:40:21 EST
If you don't have an "interface" tab then try to run:

gconftool-2 --type boolean --set /desktop/gnome/interface/menus_have_icons true

It works for me (Fedora 13)
Comment 13 Paul Webster CLA 2011-05-27 07:05:15 EDT
*** Bug 313253 has been marked as a duplicate of this bug. ***
Comment 14 Eric Williams CLA 2015-08-31 13:31:09 EDT
Icons are disabled by default in GNOME3 and must be enabled using the following command entered into the terminal:
gsettings set org.gnome.settings-daemon.plugins.xsettings overrides "{'Gtk/ButtonImages': <1>, 'Gtk/MenuImages': <1>,'Gtk/EnablePrimaryPaste': <0>}"

For older versions of GNOME3, the gconftool fix posted earlier in this thread works.

For Gtk3 this is now moot since Eclipse now uses custom constructed menus, as per bug 470298. Gtk2 menus will still need to be enabled using the command above or the gconftool.

Marking as fixed.