349510 – add maximize button to private notes section

Bug 349510 - add maximize button to private notes section

Summary: add maximize button to private notes section

Status:	RESOLVED FIXED

Alias:	None

Product:	z_Archived
Classification:	Eclipse Foundation
Component:	Mylyn (show other bugs)
Version:	unspecified
Hardware:	PC Windows 7

Importance:	P3 enhancement (vote)
Target Milestone:	3.7
Assignee:	Sam Davis
QA Contact:

URL:
Whiteboard:
Keywords:	bugday, contributed, helpwanted

Depends on:
Blocks:	158921
	Show dependency tree

Reported:	2011-06-15 19:10 EDT by Sam Davis
Modified:	2012-01-05 18:49 EST (History)
CC List:	1 user (show)

See Also:

Attachments
patch (1.36 KB, patch) 2011-12-21 20:48 EST, Sam Davis	no flags	Details \| Diff
mylyn/context/zip (97.42 KB, application/octet-stream) 2011-12-21 20:48 EST, Sam Davis	no flags	Details
updated (6.38 KB, patch) 2012-01-03 16:59 EST, Sam Davis	no flags	Details \| Diff
mylyn/context/zip (69.62 KB, application/octet-stream) 2012-01-03 16:59 EST, Sam Davis	no flags	Details
patch (5.18 KB, patch) 2012-01-05 16:24 EST, Sam Davis	steffen.pingel: iplog+	Details \| Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Sam Davis

2011-06-15 19:10:55 EDT

It would be great to have a maximize button for the private notes section. Current workaround is to fill it with text and close and reopen the task. That makes it bigger but not maximized.

Comment 1 Steffen Pingel

2011-07-26 14:10:47 EDT

Agreed. I am marking this as helpwanted to indicate that this would be a great enhancement to resolve through a contribution. Note bug 288171 which should provide the necessary API to make this fairly easy to implement.

Comment 2 Sam Davis

2011-12-21 20:48:08 EST

Created attachment 208715 [details]
patch

Comment 3 Sam Davis

2011-12-21 20:48:11 EST

Created attachment 208716 [details]
mylyn/context/zip

Comment 4 Steffen Pingel

2011-12-23 13:14:56 EST

Thanks for the patch. Looks good. Only minor nit I noticed is that the section is also enlarged when not expanded resulting in a lot of blank space in the task editor. Could fix that?

Comment 5 Sam Davis

2012-01-03 16:59:12 EST

Created attachment 208969 [details]
updated

Comment 6 Sam Davis

2012-01-03 16:59:15 EST

Created attachment 208970 [details]
mylyn/context/zip

Comment 7 Steffen Pingel

2012-01-05 14:57:49 EST

Sam, can you elaborate on the changes? It's not obvious to me what the purpose of layoutControl is. Have you tried using CommonFormUtil.setExpanded() to expand the section? That should trigger the expansion event.

Comment 8 Sam Davis

2012-01-05 16:24:53 EST

Created attachment 209105 [details]
patch

layoutControl has a GridLayout, which is needed for the maximize action to work; setting a GridData on the section client would have no effect.

Thanks for the tip about CFU; here's an updated patch that gets rid of the unnecessary listener.

Comment 9 Steffen Pingel

2012-01-05 18:49:12 EST

Great! I have applied the patch to master.