Community
Participate
Working Groups
Currently a maximize button appears on the toolbar of the task description and new comment parts, and can be enabled on any TaskEditorRichTextPart that a client may create. It would be beneficial to have the maximize capability for other types of parts as well, especially if that part has a similarly large control that could present a full screen of data, such as a table or a tree.
Created attachment 146106 [details] Patch to add toggle maximize button to any AbstractTaskEditorPart This patch involves the following changes: * Moving the ToggleToMaximizeAction up one class in the hierarchy * Changing calls in its run() method from getEditor().getControl() to getControl() (please verify that these calls are equivalent) * Implementing isAutoTogglePreview in the new comment part * Moving isAutoTogglePreview and getMaximizeAction up once class in the hierarchy A new part that implements AbstractTaskEditorPart can then add a toggle to maximize button by adding toolbarManager.add(getMaximizeAction()) in fillToolbar. This was left to subclasses, e.g., the TaskRichEditorPart already has logic determining when to add the button. This patch has been tested on the default bugzilla editor. It has also been tested with a new part that has a treeviewer.
Created attachment 146107 [details] mylyn/context/zip
Created attachment 146927 [details] updated patch
The patch changes how the maximize actions works. Previously the action set layout constraints on the editor control nested within the task editor part, with the patch applied the action modifies the grid data of the part's control (typically a section). This seems right to me but unfortunatelly breaks for editable descriptions (e.g. for JIRA tasks). If you can fix that I'll consider the patch. I attached an updated version that remove the unneeded isAutoToggle() flag.
That would actually benefit the Reviews project too, as we could use this functionality. I've applied the patch and tested it (Bugzilla, JIRA and Mylyn Reviews) and it seems to work for me.
Ok, I'll tentatively schedule it. I'll need to verify whether the concern in comment 4 needs to be addressed.
Created attachment 176862 [details] patch that addresses comment 4
Created attachment 176863 [details] mylyn/context/zip
Kilian, can you verify if the latest patch works for you?
I have applied the patch to head. Please reopen if you run into any problems.
