Community
Participate
Working Groups
The reply button on review comments doesn't work. I think this should open the post comments dialog and prefill with comment with a quoted version of the comment in question.
Replying is not yet supported but would be a very useful addition.
*** Bug 389931 has been marked as a duplicate of this bug. ***
Correct me if I'm wrong, but it appears to be the case that the only way global commenting is supported now is through publish comment. I'd like to go ahead and add a New Comment box to the task editor as well, unless anyone objects..
Hmm... this begs the question of whether we want a global "Review" or "Submit" action (and Actions section?) that would trigger publishing of the comments dialog (and any draft comments..?) If we don't support this, the Reply to Functionality doesn't really make sense either, as we don't have any where to put the replied comment or to trigger it's being submitted. (We could just take the value and put it in the publish comments dialog, which is what I'll do for a first pass, but that workflow is pretty weird / nonintuitive.
https://git.eclipse.org/r/#/c/9089/
This is directly related to bug 370645. Gerrit would need to integrate with the standard editor submit functionality and provide a comment attribute as proposed in the review. At least the publish action would need to be triggered through the editor to support this (which may be a reasonable effort overall).
Right, on submit button, I was thinking we could just provide the PublishCommentDialog. As a variation, we could assume that the comment was what they wanted, and provide a simple confirm dialog. I'd like to do away with the confirm altogether, but I gather that isn't easy to do under the current design..we would also miss the "opportunity" to inform user of number of drafts, but I don't think that's neccessary and isn't provided w. Gerrit Web Ui in any case. Thoughts? Worth doing for this bug or should we hold on it?
(edited summary to reflect widening of scope and distinguish between this and replying to comments in artifact editors.)
We should remove the confirmation dialog. Currently it supports voting which would need to be integrated with the editor first. It's also possible to publish comments for older patch sets which is something we should support as well. I would propose to polish the current review, merge it and track all further improvements under bug 370645.
(In reply to comment #9) > We should remove the confirmation dialog. I assume you mean "eventually" not "now" as part of https://git.eclipse.org/r/#/c/9089/? (We can't do so now as as you point out below that would leave the user no way to vote.) > Currently it supports voting which > would need to be integrated with the editor first. It's also possible to > publish comments for older patch sets which is something we should support > as well. I would propose to polish the current review, merge it and track > all further improvements under bug 370645. +1 So unless I misunderstood I'm going to address the tow other things you noticed on the review and we can hopefully leave it at that for now.
I have merged the latest patch set into master. Thanks very much for the contribution, Miles!
Marking resolved.
