Bug 33704 - CVS commands should not work recursively on packages
Summary: CVS commands should not work recursively on packages
Status: RESOLVED WORKSFORME
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 2.1   Edit
Hardware: PC Windows 2000
: P3 critical (vote)
Target Milestone: ---   Edit
Assignee: Platform-VCM-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 68332 (view as bug list)
Depends on:
Blocks:
 
Reported: 2003-03-03 17:04 EST by Graham Johnson CLA
Modified: 2005-06-22 12:11 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Graham Johnson CLA 2003-03-03 17:04:09 EST
If I right-click on a package in the Package Explorer and issue a CVS command
(such as Update), it operates recursively.  It should not.  Example:

***
cvs update -C -d -P "/drools/src/java/test/org/drools/reteoo"
  cvs server: Updating src/java/test/org/drools/reteoo
  cvs server: Updating src/java/test/org/drools/reteoo/impl
ok (took 0:00.310)
***

Packages like "org.eclipse" and "org.eclipse.foo" in Java are appropriately not 
shown nested in Package Explorer because they don't inherit anything, and 
similarly, actions done to one package from Package Explorer should not affect 
class files in another just because they happen to share part of their name.  
Recursive CVS behavior is potentially quite dangerous, and is confusing since 
the non-nested arrangement in Package Explorer suggests the operations will not 
be recursive.  In the example above, the second package should not have been 
updated.

The commands issued by the popup menus for packages need to be changed to use 
the -l option instead of the default recursive behavior.

I am using 2.1 RC1.
Comment 1 Dirk Baeumer CLA 2003-03-04 03:52:32 EST
Asking Team how this can be achived.
Comment 2 Jean-Michel Lemieux CLA 2003-03-04 09:37:03 EST

*** This bug has been marked as a duplicate of 33210 ***
Comment 3 Graham Johnson CLA 2003-03-04 15:19:48 EST
This is not the same problem as 33210.  This problem is specific to how CVS 
commands should work when done from a package icon/tree entry in the Package 
Explorer.
I am not experiencing the problems reported in 33210.

To reiterate, the commands issued by the popup menus for packages need to be 
changed to use the -l option instead of the default recursive behavior.
Comment 4 Dirk Baeumer CLA 2004-06-23 13:13:37 EDT
*** Bug 68332 has been marked as a duplicate of this bug. ***
Comment 5 Randy Hudson CLA 2004-06-23 15:55:47 EDT
This is very dangerous when invoking "Replace With->Latest From $STREAM$"
Nested outgoing changes get lost unexpectedly.  Furthermore, the lost changes 
are not even available in my local history despite my setting the limit to 50.
Comment 6 Randy Hudson CLA 2004-06-23 16:01:36 EDT
If bad decorators are "critical", then losing lots of code must be at least as 
bad. (see Bug 3979)
Comment 7 Michael Valenta CLA 2005-05-09 14:28:23 EDT
Support for this was added in 3.1. CVS operations on Java packages are not 
recursive.
Comment 8 xordos CLA 2005-06-22 11:48:48 EDT
Is this behaviour have an option to select one or the other? I used to use
"Tree" layout, and everything works recursively, but now "synchronized cvs"
works recursively, but cvs update/commit doesn't...feels like a bug...:(
Comment 9 Michael Valenta CLA 2005-06-22 12:11:47 EDT
Xordos, you should log a bug against JDT UI for this. The intention is that 
the depth of the operation match what is displayed in the view. If the view is 
deep, the operation should be deep. It is the view displaying the resources 
that controls this.