Bug 333898 - [Preferences] [accessibility] Preferences Dialog menu button needs a tooltip
Summary: [Preferences] [accessibility] Preferences Dialog menu button needs a tooltip
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.6.2   Edit
Assignee: Oleg Besedin CLA
QA Contact:
URL:
Whiteboard:
Keywords: accessibility
Depends on: 325899
Blocks:
  Show dependency tree
 
Reported: 2011-01-10 14:12 EST by Oleg Besedin CLA
Modified: 2011-05-18 16:47 EDT (History)
7 users (show)

See Also:
Mike_Wilson: pmc_approved+
bokowski: review+

Attachments
Patch (3.80 KB, patch)
2011-01-10 15:03 EST, Oleg Besedin CLA 		no flags Details | Diff
Patch updated (3.78 KB, patch)
2011-01-10 15:33 EST, Oleg Besedin CLA 		no flags Details | Diff
Follow-up patch to avoid new message (2.67 KB, patch)
2011-01-20 10:04 EST, Markus Keller CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oleg Besedin CLA 2011-01-10 14:12:07 EST 
I cloned the 3.7 bug to record backport into 3.6.2.

+++ This bug was initially created as a clone of Bug #325899 +++

Build id: I20100915-2024
org.eclipse.ui.internal.dialogs.FilteredPreferenceDialog

In method getContainerToolBar(Composite composite) of FilteredPreferenceDialog class, the popupMenuAction needs toolTipText (or it can perhaps just have "text", which the ToolBarManager will use for the tooltipText because the toolItem is showing an image).

This is needed for accessibility: screen readers need to have a name, and the ToolBarManager class provides a name based on the tooltipText.
Comment 1 Oleg Besedin CLA 2011-01-10 15:03:52 EST 
Created attachment 186417 [details]
Patch
Comment 2 Oleg Besedin CLA 2011-01-10 15:05:52 EST 
Boris, could you have a look?
Comment 3 Boris Bokowski CLA 2011-01-10 15:31:10 EST 
+1 if the string is change to something more generic, like "Dialog menu" or just "Menu". The reason is that this tooltip is going to be displayed in the properties dialog too.
Comment 4 Oleg Besedin CLA 2011-01-10 15:33:22 EST 
Created attachment 186421 [details]
Patch updated

Yes, nice catch! Updated string to simply read "Menu".
Comment 5 Oleg Besedin CLA 2011-01-11 09:39:10 EST 
Patch applied to the R3_6_maintenance branch. Thanks everybody!
Comment 6 Markus Keller CLA 2011-01-20 10:04:20 EST 
Created attachment 187190 [details]
Follow-up patch to avoid new message

(In reply to comment #4)
It's always problematic to add new NLS messages in maintenance releases, since language packs are typically only created once per main release.

In HEAD, it's good that you use a separate message, but for 3.6.2, it would be better to reuse an existing message. My patch uses the equivalent message from the FilteredItemsSelectionDialog.
Comment 7 Oleg Besedin CLA 2011-01-21 10:29:04 EST 
(In reply to comment #6)
> It's always problematic to add new NLS messages in maintenance releases, since
> language packs are typically only created once per main release.

Good point, patch released into the maintenance stream. Thank you!
Comment 8 Markus Keller CLA 2011-02-11 13:20:54 EST 
Verified in M20110210-1200.