Community
Participate
Working Groups
Build id: I20100915-2024 org.eclipse.ui.internal.dialogs.FilteredPreferenceDialog In method getContainerToolBar(Composite composite) of FilteredPreferenceDialog class, the popupMenuAction needs toolTipText (or it can perhaps just have "text", which the ToolBarManager will use for the tooltipText because the toolItem is showing an image). This is needed for accessibility: screen readers need to have a name, and the ToolBarManager class provides a name based on the tooltipText.
Would be nice if this could go into 3.6.2. It should be a very simple fix.
Created attachment 179341 [details] screen snap of preferences dialog In case it is useful, here is a screen snapshot of the tool item that needs a tooltip. I can verify the fix, if you like, or if you have a copy of inspect32.exe, you can look to make sure the button has an accName when it gets focus.
Created attachment 180684 [details] Patch
Patch applied to CVS Head.
Verified in I20101026-2000.
Created attachment 184642 [details] screenshot of properties dialog Unfortunately, this bug also affects PropertyPage (see screenshot). It would be fantastic if the fix for this could make it into 3.6.2.
Reopened to address comment 6.
(In reply to comment #6) > Created an attachment (id=184642) [details] > screenshot of properties dialog > Unfortunately, this bug also affects PropertyPage (see screenshot). It would > be fantastic if the fix for this could make it into 3.6.2. Where that dialog is coming from? The drop-down "triangle" button is from the dialog, not the property page. The only other place that adds that drop down in the SDK that I can find is the FilteredItemsSelectionDialog, and that adds a "Menu" tooltip. (Visisble in, say, "Open Resource" dialog, Ctrl+Shift+R.)
Select a project in the Package Explorer and choose "Properties" from the context menu. The menu button is on the top right. If possible, please also release both fixes for 3.6.2 (i.e. the fix in comment 3, and the fix for this property page dialog). Thanks!
Created attachment 185456 [details] Screenshot of 3.7M3 (In reply to comment #9) > Select a project in the Package Explorer and choose "Properties" from the > context menu. The menu button is on the top right. That is fixed in 3.7M3, see the attached screenshot? That's why I am asking Allan which SDK dialog he is using in his screenshot.
Thanks, Oleg. I believe Allan is still on Eclipse 3.5 (He is using Jazz). We were hoping that the fix could go into 3.6.2, so that Jazz based products can have it before Eclipse 3.7.
The screenshot that Allan attached does not look like the FilteredPreferenceDialog (which is shown in the Carolyn's screen snap). For starters, there is no filter field in there. I've searched through the Platform code and FilteredPreferenceDialog is the only dialog that I can find with the drop-down triangle button that did not have a tooltip. The 3.4 and 3.6 SDKs have property dialogs with filter fields so this does not seem to be something changed in 3.6+. So, my suspicion is that the properties dialog that Allan sees does not come from the Platform UI. That's why I asked in the comment 8 what is the Eclipse dialog that needs to be fixed.
I had a chat with Allan and he confirmed that, indeed, it is the PropertyDialog that is used in his screenshot. I'll mark again this bug as fixed and will open a clone for 3.6.2 backport.
The 3.6 backport is in the bug 333898.
Updated tooltip text to be "Menu", see bug 333898 comment 3 .
Verified in I20110307-2110.
*** Bug 345769 has been marked as a duplicate of this bug. ***
This didn't make it into 4.x. NOTE: This was requested to backport, hence it should probably also go into 4.1.1.
.
Copied changes into R4_development stream.
