Bug 321018 - Commit dialog: embedded compare editor instead of opening a new window
Summary: Commit dialog: embedded compare editor instead of opening a new window
Status: NEW
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 0.9.0   Edit
Hardware: PC Linux
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, helpwanted
Depends on:
Blocks:
 
Reported: 2010-07-27 10:08 EDT by Benjamin Muskalla CLA
Modified: 2013-11-14 19:45 EST (History)
2 users (show)

See Also:

Attachments
cvs dialog (84.96 KB, image/png)
2010-07-27 10:09 EDT, Benjamin Muskalla CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Muskalla CLA 2010-07-27 10:08:36 EDT 
The compare feature in the Commit dialog is not easy to find as nobody expects that a doubleclick does anything in that case. The CVS commit dialog has an additional button to show a compare pane to show the compare pane as part of the dialog.

In addition, a tree representation makes more sense in my eyes to show the changed files.

Will provide a patch if you want.
Comment 1 Benjamin Muskalla CLA 2010-07-27 10:09:03 EDT 
Created attachment 175318 [details]
cvs dialog
Comment 2 Stefan Lay CLA 2010-07-27 10:51:57 EDT 
There was once a longer discussion about a new commit dialog: see bug 310128.

But I think that an iterative approach is reasonable here.

Maybe we can later on add Remy's idea of a staging area  (bug 313263) to the commit dialog.
Comment 3 Robin Stocker CLA 2013-09-27 11:35:58 EDT 
Showing the compare editor within the same dialog would still be nice (although I personally only use the staging view).
Comment 4 David M. Karr CLA 2013-11-14 16:45:37 EST 
Frankly, an easier fix to this interface problem is simply to put the compare option in the right-click context menu.  Putting it on double-click is completely non-obvious.
Comment 5 Robin Stocker CLA 2013-11-14 19:45:10 EST 
(In reply to David M. Karr from comment #4)
> Frankly, an easier fix to this interface problem is simply to put the
> compare option in the right-click context menu.  Putting it on double-click
> is completely non-obvious.

See the change for this in bug 421491. Having the compare view embedded would still be nice in addition to that.