Bug 421491 - Commit dialog: allow "Compare With" "Previous Revision" using context menu
Summary: Commit dialog: allow "Compare With" "Previous Revision" using context menu
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows 7
: P3 enhancement (vote)
Target Milestone: 3.2   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-11 18:14 EST by David M. Karr CLA
Modified: 2013-11-15 09:10 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David M. Karr CLA 2013-11-11 18:14:37 EST
In Subversive/Subclipse, while sitting on the commit dialog, a user can right-click on each resource pending commit and see the local changes, so the user can easily write a commit message comprising all of the changes.  The EGit commit dialog needs a similar feature.
Comment 1 Matthias Sohn CLA 2013-11-12 12:23:00 EST
EGit already provides 2 options:
- in commit dialog double-click the file and you'll get a compare view
- use the staging view which is non-modal and allows to use the full workbench while incrementally staging files and incrementally preparing the commit message
Comment 2 Robin Stocker CLA 2013-11-12 15:26:21 EST
Also see bug 321018 which is about showing the compare view inside the commit dialog instead of a new window.
Comment 3 David M. Karr CLA 2013-11-14 16:43:58 EST
If it matters, I would point out that the way that is done in the commit dialog is not a very good interface design.  Actions bound to multi-clicks should just be shortcuts to actions available without multi-clicks.  It makes accessibility more difficult, for one.  You should have "compare" options in the right-click context menu.

I'm not saying there's anything particular wrong with having that action on double-click, but that shouldn't be the only way to get to it.
Comment 4 Robin Stocker CLA 2013-11-14 19:44:14 EST
You're right, it would be better if it was also available in the context menu. Change for implementing this: https://git.eclipse.org/r/18416
Comment 5 Matthias Sohn CLA 2013-11-15 06:46:02 EST
merged as 84294240688eaff89bbf9515c2173dea0c5c8ec4