Community
Participate
Working Groups
Some discussions can be seen in bug 309582 and bug 310128. A suggested implementation has been pushed to Gerrit for review. http://egit.eclipse.org/r/716
Anyone have an idea how hard would this would be to integrate into the Synchronize view as another option to view the data? Just a thought to simplify the additions of more views if not necessary.
An updated rebase of Remy's original work has been pushed to Gerrit. http://egit.eclipse.org/r/#change,3106
Created attachment 194400 [details] screenshot GitX staging view on a sample jgit change
Created attachment 194401 [details] screenshot current EGit staging view on same sample jgit change
(In reply to comment #2) > An updated rebase of Remy's original work has been pushed to Gerrit. > > http://egit.eclipse.org/r/#change,3106 I did some testing and compared this view with the staging/commit view provided by GitX. I think the UI should rather follow what GitX does, I think this is close to optimal. I would propose to do the following changes: - add a combo to select the repository, if you feel you really need a way to have a staging view for all repositories add an entry "<all>" to this combo, I think looking at staged changes for multiple repos isn't really useful and requires more scrolling - divide the staging view horizontally into three panes in the same way as GitX does: - list of unstaged files in the left pane, decorate modified, deleted, untracked files with different decorators, this removes the need for a lot of tree nodes - draft for commit message in the middle (could reuse the new stuff done by Kevin) - list of staged change on the right side, decorate to show details about staged changes - I would prefer flat file lists as this removes the need to open/collapse unnecessary tree nodes which also eat up vertical screen real estate (compare the two screenshots comparing current EGit proposal and GitX)
Created attachment 194446 [details] Initial prototype of gitx style stage view Here's a first cut of a gitx style staging view. I'm not entirely convinced by the commit button, it throws out the layout of the checkboxes (maybe some SWT magic can fix that!) but the commit portion also consumes a lot of vertical real-estate leaving the commit message input fairly constrained. For the repo selection I had thought to make it selection based so it would work like the history view and follow the current selection.
I created a CQ for Bernard's latest changes. https://dev.eclipse.org/ipzilla/show_bug.cgi?id=5115 Any additional changes should be done with a Gerrit changset on top of what we already have and kept under 250 lines if possible (per new changeset).
Created attachment 194731 [details] next iteration mockup for staging view
*** Bug 335138 has been marked as a duplicate of this bug. ***
Bernard, can you verify these statements needed by the Eclipse IP team: 1. He/She confirms they authored 100% of the content they are submitting 2. He/She confirms they have the rights to contribute the content to Eclipse 3. He/She confirms the content is being submitted under the project license in this case EPL
(In reply to comment #10) > Bernard, can you verify these statements needed by the Eclipse IP team: > > 1. He/She confirms they authored 100% of the content they are submitting > 2. He/She confirms they have the rights to contribute the content to Eclipse > 3. He/She confirms the content is being submitted under the project license in > this case EPL I can confirm that I have authored 100% of the content and have the rights to contribute the code to Eclipse and consent to the code being licensed under the EPL. This change was developed using my own time and equipment I own.
This was committed as 562ff7890f47f4be0cb9b6e76f8fc4d645374228. Any enhancements or bugs should be reported as new bugzilla entries. Thanks everyone for your patience.
