Bug 318649 - Create patch should support viewing a patch without saving
Summary: Create patch should support viewing a patch without saving
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows Vista
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform Team Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-01 18:04 EDT by Daniel Jacobowitz CLA
Modified: 2019-09-06 16:15 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Jacobowitz CLA 2010-07-01 18:04:59 EDT
Build Identifier: 20100617-1415

I'm used to working with diffs.  I get confused easily in the team view, where I have to use side-by-side comparison instead.  So when I want to see what changes are in my workspace, I usually use Create Patch.

I'd like to be able to get a patch without it cluttering up my disk.  Right now the easiest way is to create the patch to clipboard, create a new untitled text file, and then paste.  Would it be possible to generate the patch directly to a new editor, instead?

Or maybe what I really need is a way to format the compare editor as a diff...

Reproducible: Always
Comment 1 Tomasz Zarna CLA 2010-07-02 05:28:15 EDT
(In reply to comment #0)
> Or maybe what I really need is a way to format the compare editor as a diff...

What do you mean by that?
Comment 2 Daniel Jacobowitz CLA 2010-07-02 10:10:34 EDT
Something else than my original issue, not fully thought out.  When I want to see the changes to a single file, again, I find diffs more familiar than the side-by-side comparison editor.  It conveys the same information, though, so you should be able to do it with similar UI.  There's an "Open in compare editor" and maybe there could be an "open as patch" also.  Is that crazy?
Comment 3 Tomasz Zarna CLA 2010-07-15 04:01:36 EDT
This makes sense to me, patch gives the same information but in a condensed form. I can imagine this to be more handy in some cases. To implement such action we will need to fix bug 71374.

As for your original request I can see three options here:
1) Add another radio button for patch location. Currently, we have Clipboard, File and Workspace. We could name it "Open in Editor" or something. This is the easiest approach, but imo it would clutter the wizard. Four radios is too much. Besides I think the fourth button wouldn't be used that often... except your case ;)
2) Another solution could be a purposed-made editor or view for displaying clipboard content. So you could stick to the Clipboard option and then open (automatically) an editor for patches (bug 190418).
3) Add a patch preview pane to the Create Patch wizard. This could be similar to how file content changes pane in Commit Wizard works. But we would display diff not content changes as in Compare Editor.
Comment 4 Daniel Jacobowitz CLA 2010-07-15 13:32:22 EDT
IMO the fourth radio button is not too much, if it has a concise description.
Comment 5 Eclipse Webmaster CLA 2019-09-06 16:15:58 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.