Bug 308907 - [Help] Allow filtering in help view contents and index tabs
Summary: [Help] Allow filtering in help view contents and index tabs
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: User Assistance (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 3.7 M5   Edit
Assignee: Chris Goldthorpe CLA
QA Contact:
URL:
Whiteboard:
Keywords: polish
Depends on: 303104
Blocks: 326001
  Show dependency tree
 
Reported: 2010-04-12 13:50 EDT by Chris Goldthorpe CLA
Modified: 2011-01-06 13:00 EST (History)
5 users (show)

See Also:


Attachments
Patch to add filtering to index and all topics views (36.84 KB, patch)
2011-01-04 17:14 EST, Chris Goldthorpe CLA
no flags Details | Diff
Patch to initialize new scope to default (952 bytes, patch)
2011-01-05 13:57 EST, Chris Goldthorpe CLA
no flags Details | Diff
Patch to leave OK button enabled (930 bytes, patch)
2011-01-06 12:58 EST, Chris Goldthorpe CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Goldthorpe CLA 2010-04-12 13:50:15 EDT
+++ This bug was initially created as a clone of Bug #303104 +++

In Eclipse 3.6 filtering is being added to the help infocenter but due to schedule constraints not to all tabs in the help view, only the search tab is filtered by criteria. This enhancement request is to track the remaining work to add filtering to the help view.
Comment 1 Holger Voormann CLA 2010-09-20 17:27:26 EDT
I like to propose following enhancements/polishing (see mockup https://bugs.eclipse.org/bugs/attachment.cgi?id=179263):

1. Skip prefix "Result for scope" because the scope name only is sufficient and clear

2. Add a "Close" button to the right because if the scope is set by mistake then you like to deactivate it
Comment 2 Holger Voormann CLA 2010-09-21 13:34:28 EDT
(In reply to comment #1)
> I like to propose following enhancements/polishing (see mockup
> https://bugs.eclipse.org/bugs/attachment.cgi?id=179263):
> 
> 1. Skip prefix "Result for scope" because the scope name only is sufficient and
> clear
> 
> 2. Add a "Close" button to the right because if the scope is set by mistake
> then you like to deactivate it

Oops, wrong bug: I mistake it for bug 305895. Please ignore my comment above.
Comment 3 Martin Oberhuber CLA 2010-11-19 06:20:13 EST
Chris, is the target milestone accurate, ie. is this really going into M4 ?
Comment 4 Chris Goldthorpe CLA 2010-11-19 13:08:45 EST
No, it needs to be moved to M5.
Comment 5 Chris Goldthorpe CLA 2011-01-04 17:14:19 EST
Created attachment 186056 [details]
Patch to add filtering to index and all topics views

This patch adds filtering to the all topics and index views but not to the "See Also" part. I'm not so sure that filtering the see also part would improve the user experience since the purpose of filtering is to eliminate topics that may not be relevant. The topics list under see also are all relevant so filtering is not necessary and could end up hiding useful links. I will commit the current patch now and await feedback on whether All Topics should be filtered.
Comment 6 Chris Goldthorpe CLA 2011-01-05 13:57:04 EST
Created attachment 186109 [details]
Patch to initialize new scope to default

An NPE was generated when no scope was selected and the new button was pressed. This is because the new scope is created as a copy of the selected scope. This patch changes all new scopes to be initialized to the same default values. I have applied the patch to HEAD.
Comment 7 Chris Goldthorpe CLA 2011-01-06 12:58:25 EST
Created attachment 186203 [details]
Patch to leave OK button enabled

After committing the previous patches I discovered that the OK button was disabled when the last scope set was removed. The OK button should always be enabled because the default scope always exists and does not appear in the list.
Comment 8 Chris Goldthorpe CLA 2011-01-06 13:00:00 EST
I have committed the patches, filtering is now enabled in the index view and table of contents view.