Bug 30072 - adopt Assert
Summary: adopt Assert
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Runtime (show other bugs)
Version: 2.1   Edit
Hardware: PC Windows 2000
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Oleg Besedin CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-01-23 04:38 EST by Adam Kiezun CLA
Modified: 2006-08-31 06:01 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Kiezun CLA 2003-01-23 04:38:39 EST 
we have 9 copies in the SDK !
jface is independent from core so we should at most need 2
Comment 1 John Arthorne CLA 2003-09-10 17:07:36 EDT 
There's no point exposing Assert now that we are using JDK 1.4.  You can now use
the assert keyword.
Comment 2 Adam Kiezun CLA 2003-09-10 17:13:32 EDT 
the assert keyword is bogus - you have to _explicitly_ turn on the runtime check
for it. that means we will not delete the 9 Assert classes that we have.
Comment 3 John Arthorne CLA 2005-11-14 14:28:24 EST 
Reopening for consideration
Comment 4 Oleg Besedin CLA 2006-02-14 13:29:22 EST 
The org.eclipse.core.runtime.Assert class has been exposed as a public API by the org.eclipse.equinox.common plugin and re-exported by the org.eclipse.common.runtime.

The "other" Assert's are present in the:
org.eclipse.jdt.core.tests.builder
org.eclipse.core.internal.expressions
org.eclipse.core.internal.runtime
org.eclipse.jdt.internal.core
org.eclipse.jdt.internal.corext
org.eclipse.test.internal.performance.data
org.eclipse.ui.internal.misc
org.eclipse.update.internal.core
org.eclipse.webdav.dom
org.eclipse.webdav.internal.kernel.utils

(+ 2 Jface cases that probably can be combined)

Plus, the AssertionFailedException now exposed as an API in the same way and is duplicated by:
org.eclipse.core.internal.expressions
org.eclipse.jdt.core.tests.builder
org.eclipse.webdav.internal.kernel.utils
org.eclipse.jdt.internal.compiler.flow
org.eclipse.jdt.internal.core
org.eclipse.test.internal.performance.data
org.eclipse.webdav.dom
Comment 5 Pascal Rapicault CLA 2006-03-23 13:40:49 EST 
Oleg could you please open bug reports against the various components that still use Assert (even better provide patch) and then close this bug.
Comment 6 Oleg Besedin CLA 2006-04-05 16:34:22 EDT 
The Assert and AssertionFailedException are now provided by the org.eclipse.equinox.common plugin (package org.eclipse.core.runtime).

I recorded individual bugs for the plugins in the eclipse.org repository that depend on org.eclipse.equinox.common and provide they own copies of Assert or AssertionFailedException classes:

Bug 135110
Bug 135134
Bug 135135
Bug 135136
Bug 135139
Bug 135140
Comment 7 Dani Megert CLA 2006-08-31 06:01:09 EDT 
Filed bug 155788 for org.eclipse.jface.util.Assert.