Bug 135110 - Duplicate Assert class in org.eclipse.core.internal.expressions
Summary: Duplicate Assert class in org.eclipse.core.internal.expressions
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2 RC1   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-04-05 15:03 EDT by Oleg Besedin CLA
Modified: 2006-04-13 10:28 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oleg Besedin CLA 2006-04-05 15:03:43 EDT 
There is an org.eclipse.core.internal.expressions.Assert class that seems to be very similar to org.eclipse.core.runtime.Assert available in Eclipse 3.2.

As those classes seem to provide the same functionality, perhaps org.eclipse.core.internal.expressions.Assert could be removed and references to it changed to refer to the runtime class.

Same goes for the org.eclipse.core.internal.expressions.AssertionFailedException and org.eclipse.core.runtime.AssertionFailedException.

This bug is recorded from the general bug 30072.
Comment 1 Oleg Besedin CLA 2006-04-05 15:07:30 EDT 
Actually, there is one more duplicate pair in JDT:
org.eclipse.jdt.core.tests.builder.Assert
org.eclipse.jdt.core.tests.builder.AssertionFailedException

Those could be removed as well.
Comment 2 Olivier Thomann CLA 2006-04-05 15:12:56 EDT 
I removed the two classes Assert and AssertionFailedException that were unused.
But the ones in org.eclipse.core.internal.expressions are not in JDT/Core.
So please open a new bug report for them.
Fixed and released in HEAD.
Comment 3 Olivier Thomann CLA 2006-04-05 15:13:12 EDT 
Reopen to assign
Comment 4 Olivier Thomann CLA 2006-04-05 15:13:32 EDT 
Fixed and released in HEAD.
Comment 5 Oleg Besedin CLA 2006-04-05 16:13:45 EDT 
Sorry, there is one duplicate in JDT/Core:
org.eclipse.jdt.internal.core.Assert
Comment 6 Olivier Thomann CLA 2006-04-05 21:53:55 EDT 
Fixed and released in HEAD.
Comment 7 Philipe Mulet CLA 2006-04-09 07:24:15 EDT 
+1 for 3.2RC1
Comment 8 David Audel CLA 2006-04-13 10:28:47 EDT 
Verified for 3.2 RC1 using build I20060413-0010