Bug 298100 - [Filters] Resource Filters could use Markers to keep filter descriptions
Summary: [Filters] Resource Filters could use Markers to keep filter descriptions
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Resources (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform-Resources-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 295063
  Show dependency tree
 
Reported: 2009-12-17 12:26 EST by Szymon Brandys CLA
Modified: 2015-04-01 09:50 EDT (History)
3 users (show)

See Also:

Attachments
Proposal v01 (dirty) (31.67 KB, patch)
2009-12-17 12:35 EST, Szymon Brandys CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Szymon Brandys CLA 2009-12-17 12:26:43 EST 
While working on bug 295063 I realized that we need a similar mechanism for tracking filter deltas and sending POST_CHANGE events as we have for markers. Thus I thought that I could use markers to keep resource filter descriptions.

Advantages of this approach are: 
- we reuse robust mechanism to store filter descriptions
- we don't have to duplicate code to have POST_CHANGE events for filter descriptions
- when resources are copied, moved etc. filters descriptions are handled like regular markers, what means no extra code is needed to handle filter descriptions

I'm attaching a dirty patch illustrating this approach. One extra thing that needs to be implemented is storing the new filtermarkers, since they are non-persistent.  They need to be stored somewhere in the project folder, either in .project or as project preferences.
Comment 1 Szymon Brandys CLA 2009-12-17 12:35:22 EST 
Created attachment 154680 [details]
Proposal v01 (dirty)
Comment 2 Serge Beauchamp CLA 2010-01-04 10:28:12 EST 
Looks like a great way to refactor the filter implementation by re-using the existing marker implementation.
Comment 3 Szymon Brandys CLA 2010-04-21 10:22:54 EDT 
Moving to 3.7. The only issue here is that there is no mechanism to persist markers in the project area. I think we should enhance markers first and then adapt it in filters.
Comment 4 Szymon Brandys CLA 2011-03-22 13:02:47 EDT 
Moving to 3.8. Need to investigate whether we need to make this enhancement to fix bug 295063.
Comment 5 Szymon Brandys CLA 2015-04-01 09:50:10 EDT 
I am no longer involved in Platform Core development.