Community
Participate
Working Groups
Build id: I20091110-0800 Steps: 1) Add a general project 2) Go to its properties, add a filter and Apply See, that the overlay icon doesn't show up. You have to refresh the project or click on it.
This is happening only when the filter causes no change in the workspace hierarchy. When only the filter change, there's no change delta is is broadcasted, and the resource icon isn't updated. I was looking at where does the change delta comes from when renaming a project, for instance, and it seems to come from the UI code, in UserINputWizardPage.java, in: CreateChangeOperation create= new CreateChangeOperation( new CheckConditionsOperation(refactoring, CheckConditionsOperation.FINAL_CONDITIONS), threshold); PerformChangeOperation perform= new UIPerformChangeOperation(getShell().getDisplay(), create, getContainer()); Is that possible? In such case, would it be up to the ui.ide change UI to cause that delta to be sent rather than the core.resources plugin itself?
I think that we could use a similar mechanism that we already have for markers. See Resource#createMarker which generates delta on marker creation.
I'm not sure to fully understand the market refresh mechanism, but would this mean we'd have to create a core constant for M_FILTERS_SNAP_DIRTY, and set that flag when a filter is create/removed? I tried to implement that, but it didn't work. What's the trigger that cause that resources to be dirty and cause a delta to be broadcasted for the markers?
Hi Serge, see NotificationManager#broadcastChanges and then #getDelta. You will see that the marker manger is requested for markers deltas. If you look at MarkerManager, you will find a delta manger that handles deltas. Looking at Resource#createMarker you will see that it calls MarkerManager#changedMarkers at some point what updates the marker delta information. I hope it helps. Maybe we should introduce a filter manager that keeps deltas etc.
I'm taking over this one.
Moving to 3.7. We need to fix bug 298100 first.
Moving to 3.8.
I am no longer involved in Platform Core development.
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug. If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie.
