Bug 294165 - Bugfix4Workaround: CCombo drawn without border on Windows XP with XP skin
Summary: Bugfix4Workaround: CCombo drawn without border on Windows XP with XP skin
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.0   Edit
Hardware: PC Windows XP
: P3 minor (vote)
Target Milestone: ---   Edit
Assignee: Platform-SWT-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-04 03:52 EST by T. Fischer CLA
Modified: 2019-09-06 16:16 EDT (History)
2 users (show)

See Also:


Attachments
SWT_Style_Windows_Classic_vs_XP.gif (38.37 KB, image/gif)
2009-12-17 08:26 EST, T. Fischer CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description T. Fischer CLA 2009-11-04 03:52:56 EST
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.0.14) Gecko/2009082707 Firefox/3.0.14
Build Identifier: M20090917-0800

Bug 145837 was closed with a workaround. This is not acceptable for RCP-development with Eclipse SWT, because all RCP-projects using the flat-view have to find the bug and consider it.

Reproducible: Always
Comment 1 Felipe Heidrich CLA 2009-11-04 10:10:59 EST
Not sure I understand the problem, if you create ccombo with SWT.BORDER it has border, if you don't create ccombo with SWT.BORDER it doesn't have border.

am i missing something simple ?
Comment 2 T. Fischer CLA 2009-11-09 07:47:42 EST
With Windows XP, I will either have a problem with the default- or with the classic-design theme.

If I create a CCombo with SWT.BORDER it has a double border (looking wrong) in the classic- and a single border in the default-design.

If I create a CCombo without SWT.BORDER it has a single border in the classic- and no border (looking wrong) in the default-design.

If I use a Combo (not CCombo), I do not get the flat-look in the classic design.

I do not know if the problem is reproducible on later Windows versions.
Comment 3 T. Fischer CLA 2009-12-17 08:26:35 EST
Created attachment 154653 [details]
SWT_Style_Windows_Classic_vs_XP.gif

Comparison of SWT-Combos with the two Windows styles:
Windows Classic: CCombo with border=false and flat is optimal
WindowsXP-Style: CCombo with border=true and flat is optimal
Problem: There is not one configuration, that looks "good" in both styles.
Comment 4 Felipe Heidrich CLA 2009-12-17 11:43:53 EST
Works for me:
public static void main (String[] args) {
	Display display = new Display();
	final Shell shell = new Shell( display );
	shell.setLayout(new GridLayout(1, true));
	CCombo cc = new CCombo(shell, SWT.NONE);
	cc.setText("SWT.NONE");
	cc = new CCombo(shell, SWT.FLAT);
	cc.setText("SWT.FLAT");
	cc = new CCombo(shell, SWT.BORDER);
	cc.setText("SWT.BORDER");
	cc = new CCombo(shell, SWT.BORDER | SWT.FLAT);
	cc.setText("SWT.BORDER | SWT.FLAT");
	shell.pack();
	shell.open();
	while( !shell.isDisposed() ) {
		if( !display.readAndDispatch() )
			display.sleep();
	}
	display.dispose();
}

What version of Eclispe are you running ?
Can you try with HEAD: http://www.eclipse.org/swt/cvs.php
Comment 5 Eclipse Webmaster CLA 2019-09-06 16:16:04 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.