Bug 145837 - [TabbedProperties] CCombo drawn without border on Windows XP with XP skin
Summary: [TabbedProperties] CCombo drawn without border on Windows XP with XP skin
Status: CLOSED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2.1   Edit
Assignee: Anthony Hunter CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 146062 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-06-07 14:44 EDT by Valentin Baciu CLA
Modified: 2006-09-26 10:22 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Valentin Baciu CLA 2006-06-07 14:44:07 EDT 
The problem is well enough described in https://bugs.eclipse.org/bugs/show_bug.cgi?id=74701 which unfortunately I cannot seem to reopen. That bug was resolved as worksforme.

More and more teams are now using the new tabbed property view to contribute property sections for various editors. The TabbedPropertySheetWidgetFactory provides a method to add a CCombo to a property section. Due to the CCombo limitation this produces property sections which are hardly readable on XP with the XP theme on. CCombos seem to be rendered OK in classical mode.

The PDE team has chosen to solve the problem locally by wrapping and delegating to either a CCombo or Combo based on the platform. See org.eclipse.pde.internal.ui.parts.ComboPart

I think asking of each CCombo client to implement this type of solution is not very practical. It would be better if a proper solution would be implemented in either the tabbed property view infrastructure or even lower in the forms or SWT. I am sure there is some history here I'm missing...
Comment 1 Anthony Hunter CLA 2006-06-08 15:01:36 EDT 
*** Bug 146062 has been marked as a duplicate of this bug. ***
Comment 2 Anders Rawlins CLA 2006-06-08 16:02:07 EDT 
Our team has found a suitable workaround in the meantime:

  TabbedPropertySheetWidgetFactory factory = getWidgetFactory();
  fTypeCombo = factory.createCCombo(composite, SWT.READ_ONLY);
  // workaround for no CCombo borders on XP
  if (factory.getBorderStyle() == SWT.BORDER) {
      fTypeCombo.setData(FormToolkit.KEY_DRAW_BORDER,
          FormToolkit.TEXT_BORDER);
  }
Comment 3 Anthony Hunter CLA 2006-07-06 14:59:34 EDT 
Delivered the suggested fix to the TabbedPropertySheetWidgetFactory to R3_2_maintenance branch for 3.2.1.
Comment 4 Boris Bokowski CLA 2006-08-29 14:24:36 EDT 
Just a reminder to release this into HEAD.
Comment 5 Anthony Hunter CLA 2006-08-29 14:47:45 EDT 
(In reply to comment #4)
> Just a reminder to release this into HEAD.

I already merged the changes in R3_2_maintenance to HEAD when I merged Bug 143936
Comment 6 Valentin Baciu CLA 2006-09-26 10:22:17 EDT 
Verified with M20060921-0945.
Comment 7 Valentin Baciu CLA 2006-09-26 10:22:57 EDT 
Closing.