Community
Participate
Working Groups
Undo/Redo do not work in Tabbed Properties View except when the contributor is an editor. It does not work in following frequent use cases: - contributor is a view - contributor is selection based - it is just an implementation of the interface and not the part itself nor its selected objects (as in case of Project Explorer / Common Navigator) Narrowed down the code dealing with installing undo/redo to TabbedPropertySheetPage#setActionBars(IActionBars actionBars)
Committed fix to R3_2_maintenance
Anthony are you also committing these to the 3.3 stream? I ask because the releng tool is not picking up the changes and I want to be sure it is a bug in the tool.
Yes, these will need to go to 3.3, but I have not merged them into HEAD yet.
The version of the plug-in should have been changed to 3.2.1 and not 3.2.100. This this changed resulted in the change to the version I am reopening this Bugzilla.
The version of the org.eclipse.ui.views.properties.tabbed plug-in has been changed to 3.2.1 in the R3_2_maintenance branch.
org.eclipse.ui.views.properties.tabbed.IActionProvider is new API in 3.2.1. Assuming there was no other way to fix this (we typically don't put new API into maintenance releases), the interface lacks an @since tag.
I also don't see IActionProvider in HEAD. Reopening to make sure this is released into HEAD as well.
(In reply to comment #7) > org.eclipse.ui.views.properties.tabbed.IActionProvider is new API in 3.2.1. > Assuming there was no other way to fix this (we typically don't put new API > into maintenance releases), the interface lacks an @since tag. Added @since 3.2.1 to IActionProvider in R3_2_maintenance
(In reply to comment #8) > I also don't see IActionProvider in HEAD. Reopening to make sure this is > released into HEAD as well. I have merged all changes in R3_2_maintenance to HEAD.
McQ, we need your approval for this (new API interface IActionProvider in 3.2.1).
Anthony, could you please explain why new API was required to fix this?
In 3.2, we introduced Project Explorer and Tabbed Properties View integration. The Project Explorer uses the Tabbed Properties View rather than the regular table format properties view. We also introduced the ability for a contributor to Project Explorer to contribute a configuration to the Tabbed Properties View. Clients can see their custom contributed content in the Project Explorer tree as well as the custom property tabs and sections in the Tabbed Properties View. Project Explorer provided the ability to add or override actions, we did not do this for the Tabbed Properties View. This specific issue was revealed with an IBM client. As a result, when a contributors element is selected in Project Explorer and then the Tabbed Properties View is selected, their actions are not enabled. This specific bugzilla raised above is for Undo/Redo global actions. The only way to fix the issue was to add extensibility to allow clients to add actions, hence IActionProvider was added. IActionProvider is triggered by a new optional attribute in the extension point, so there is zero risk of regression and the plug-in in 3.2.1 is completely backward compatible.
(In reply to comment #11) > McQ, we need your approval for this (new API interface IActionProvider in > 3.2.1). My IBM Client had a blocking defect on this and has solved by downloading Eclipse 3.2.1 and applying a fix using the new API. Backing this fix out is not an option at this point, we already released the driver.
Anthony, we treat adding new API in maintenance releases as an exremely serious issue. Even though this API seems totally reasonable, the end result is that we would now be in a situation where plug-ins can be written that would run against the maintenance release, but not against the base release. In other words, anyone who uses this API would need to require 3.2.1 in their plug-in dependencies. Ugh! In addition, maintenance release cycles are not set up to give the community time to review new API so that we could respond to their concerns. As such, if we have any doubts about the API _at_all_ then it absolutely must be moved to an internal package regardless of who has currently implemented something on some R3.2.1 development stream build. Only if we are 100% confident that this is *the* answer for R3.3 and beyond can we even consider it. Boris is the UI team API cop, please make sure that any concerns he has are addressed. If he is 100% satisfied that this API is acceptable, I will approve it.
(In reply to comment #15) > [snip] In other > words, anyone who uses this API would need to require 3.2.1 in their plug-in > dependencies. Ugh! Exactly, the IBM Client has updated his plug-in to explicitly require 3.2.1 ( [3.2.1,4.0.0) ) of org.eclipse.ui.views.properties.tabbed . And his product will be shipping on a 3.2.1 based Eclipse.
Anthony, to review the changes you released it would be good if you could attach it as a patch. Thanks! BTW, for fixes that go into maintenance releases, we (Platform/UI) always attach a patch. This makes it easier to review the changes, to back out of them if required, and to apply the same changes to two streams (in this case 3.3 and 3.2.1).
(In reply to comment #17) > Anthony, to review the changes you released it would be good if you could > attach it as a patch. Thanks! Reopening bug so that this does not fall through the cracks.
Note I am at EclipseWorld the week of Sept 5-8
Marking as fixed to have an empty query for open 3.2.1 bugs. I still need the patch though to review the changes.
