Community
Participate
Working Groups
With the addition of qacontact email to the search page (bug#288478), the email text fields are small. qa, cc check boxes may need to be collapsed into a combo.
Created attachment 147846 [details] screenshot of current ui
We should schedule a UI review of this page, we can do better.
Created attachment 155687 [details] new UI I think we should use TabFolder. Here an example how this can look. Thoughts?
That looks great! It's much cleaner than the current search UI which looks crowded. We will need to decide though whether a tabbed UI or foldable sections which we have favored so far is the better approach for this kind of dialog. I have added this as a UI review item to the next weekly call along with the changes for bug 272207 and bug 297437 which are related.
(In reply to comment #4) > That looks great! It's much cleaner than the current search UI which looks > crowded. We will need to decide though whether a tabbed UI or foldable > sections which we have favored so far is the better approach for this kind of > dialog. I have added this as a UI review item to the next weekly call along > with the changes for bug 272207 and bug 297437 which are related. Thanks Steffen, the new UI make it easy to add the missing Bug Changes input fields and for boolean charts ( solve for bug# 283200).
Frank its great that you're looking into this and (on mac) this solution looks really great. The consensus on the call today was that using tabs can result in a few issue: # Selections on other tabs are not visible # This necessitates an extra click to always check the other tabs # The user has to switch back and forth as the query is refined between the alternate tabs The proposed solution on the call was to break the dialog down into separate expandable sections. We've had success doing this with other dialogs like the Task Repository Settings Page and tasks preference page (advanced expandable section). The advantage of taking this approach is that the user can (if desired) see all possible attributes of a query in a single glance. We could have two sections, for example: Basic * Summary * Email * Product * Component * Status * Priority Advanced * Comment * Email 2 * Keywords * Severity * Resolution * Version * Milestone * Hardware * Operating System * Changed in The exact breakdown of which fields appear in basic vs advanced will be a matter of debate so expect it to change. By default we could then collapse the advanced section. If an existing query is being opened, if any attributes in the advance section are set, it would be automatically expanded. Thoughts?
Created attachment 156878 [details] patch to review Rob, can you please review this.
Created attachment 156879 [details] mylyn/context/zip
Created attachment 156888 [details] screenshot basic properties
Created attachment 156889 [details] screenshot advanced properties showing ...screenshot with both sections expanded.
Created attachment 156890 [details] minor update added keywords label and section transparency
Frank this is looking great. I've posted a few screenshots here to help elicit feedback from the others. My initial observations: * Section titles need to be larger. The start/end of the two sections isn't clear enough so perhaps a short section title might be of use here. *Changed in would probably need to be within the advanced section * I don't think it makes sense to be able to collapse the basic section so it may not even need to be a section at all (i.e. no 'basic' title is necessary) I think you're on the right track with this! Lets get others' feedback before going too much further.
Created attachment 157061 [details] screenshot of new UI I changed the background and the size of the font. Thoughts?
Frank, I forgot to add this to the conference call agenda. Adding for next weeks...
Frank, please feel free to add bugs to the meeting agenda at http://wiki.eclipse.org/Mylyn_Meetings at any time and we'll review any attached screenshots and post feedback during the next meeting.
Frank, we did the ui review on the call this morning and everyone is enthusiastic about this change! A couple suggestions were raised on the call along with a few additional improvements that will polish off the dialog: * Basic doesn't need to be a section * Advance should only open in expanded state if one of the advanced attributes has a set value * Move the 'Changed in' field to within the Advanced section * The Advanced section can just have the standard background color (instead of the lighter color currently used) * It would be a great time to add a 'Clear' button button to the left of the Update Attributes from Repository button that simply resets/clears all set values * Also, the label if you could change the Select Repository label to simply be "Repository:"
(In reply to comment #16) > Frank, we did the ui review on the call this morning and everyone is > enthusiastic about this change! A couple suggestions were raised on the call > along with a few additional improvements that will polish off the dialog: > > * Basic doesn't need to be a section > * Advance should only open in expanded state if one of the advanced attributes > has a set value > * Move the 'Changed in' field to within the Advanced section > * The Advanced section can just have the standard background color (instead of > the lighter color currently used) Sorry I did not know what I should do here. I did not change the background. I use the standard for the Searchpage. > * It would be a great time to add a 'Clear' button button to the left of the > Update Attributes from Repository button that simply resets/clears all set > values > * Also, the label if you could change the Select Repository label to simply be > "Repository:" Can I commit my changes or do you want to do a code review?
Created attachment 158781 [details] commited patch New Query did not have the Title Controls. This is now fixed!
Created attachment 158782 [details] mylyn/context/zip
Trying to search for just a summary with all of the rest of the fields cleared produces the following error: java.lang.ArrayIndexOutOfBoundsException: -1 at org.eclipse.mylyn.internal.bugzilla.ui.search.BugzillaSearchPage.getQueryParameters(BugzillaSearchPage.java:1258) at org.eclipse.mylyn.internal.bugzilla.ui.search.BugzillaSearchPage.applyTo(BugzillaSearchPage.java:2011) at org.eclipse.mylyn.tasks.ui.wizards.AbstractRepositoryQueryPage.createQuery(AbstractRepositoryQueryPage.java:110) at org.eclipse.mylyn.tasks.ui.wizards.AbstractRepositoryQueryPage.performSearch(AbstractRepositoryQueryPage.java:135) at org.eclipse.mylyn.internal.bugzilla.ui.search.BugzillaSearchPage.performSearch(BugzillaSearchPage.java:1009) at org.eclipse.mylyn.internal.tasks.ui.TaskSearchPage.performAction(TaskSearchPage.java:120) at org.eclipse.search.internal.ui.SearchDialog.performAction(SearchDialog.java:459) at org.eclipse.search.internal.ui.util.ExtendedDialogWindow.buttonPressed(ExtendedDialogWindow.java:164) at org.eclipse.jface.dialogs.Dialog$2.widgetSelected(Dialog.java:624) at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:228) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1003) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3880) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3473) at org.eclipse.jface.window.Window.runEventLoop(Window.java:825) at org.eclipse.jface.window.Window.open(Window.java:801) at org.eclipse.mylyn.internal.tasks.ui.views.TaskListFilteredTree$5.linkActivated(TaskListFilteredTree.java:242) at org.eclipse.ui.forms.widgets.AbstractHyperlink.handleActivate(AbstractHyperlink.java:233) at org.eclipse.ui.forms.widgets.ImageHyperlink.handleActivate(ImageHyperlink.java:199) at org.eclipse.ui.forms.widgets.AbstractHyperlink.handleMouseUp(AbstractHyperlink.java:327) at org.eclipse.ui.forms.widgets.AbstractHyperlink.access$2(AbstractHyperlink.java:311) at org.eclipse.ui.forms.widgets.AbstractHyperlink$4.handleEvent(AbstractHyperlink.java:125) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1003) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3880) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3473) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2405) at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2369) at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2221) at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:500) at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332) at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:493) at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149) at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:113) at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:194) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:368) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) at java.lang.reflect.Method.invoke(Unknown Source) at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:559) at org.eclipse.equinox.launcher.Main.basicRun(Main.java:514) at org.eclipse.equinox.launcher.Main.run(Main.java:1311) at org.eclipse.equinox.launcher.Main.main(Main.java:1287)
(In reply to comment #20) > Trying to search for just a summary with all of the rest of the fields cleared > produces the following error: > Fixed ClearFields Operation now use select(0) and no longer deselectAll() for the coboboxes
That seems to have fixed it!
I just spotted this issue and the last proposed design look somewhat odd to me. Here is few major concerns: * summary and comment fields are separated between basic and advanced sections * same for email and email2 * generally, separation of fields between Basic and Advanced sections not necessarily reflects the developer's workflow. E.g. not all may work off Priority and can use Severity field instead, for instance, Eclipse's own releases/milestones have pre-reqs about severity Here is couple suggestions how to address the above: * combine Summary and Comments fields into one field and just search both fields in Bugzilla * combine email and email2 fields and allow to enter multiple emails delimited by space, so you can handle the split in the code and run corresponding query * move Severity field into the Basic section
For me with latest, the search dialog comes up blank. Switching to file search and back to task search fixes the problem.
(In reply to comment #24) > For me with latest, the search dialog comes up blank. Switching to file search > and back to task search fixes the problem. I only get this when I run in Bootstrap Mode (run/debug an Eclipse Application within an Eclipse Application). For the Java Search Page I get the same result.
On Windows 7, it seems that there is some extra padding of ~200px under the update attributes and before the progress area of the wizard dialog with or without the advanced section expanded.
Created attachment 160233 [details] commited update This was not an window 7 problem. The hint is now removed in the Button container.
Created attachment 160234 [details] mylyn/context/zip
Thanks frank! was there any reason that these hints were there that you know of?
(In reply to comment #29) > Thanks frank! was there any reason that these hints were there that you know > of? No this was a cut/copy error. I did nor remove or change this when I insert this. So it is save that I have remove this.
Suggestions from today's call: * Rename Advanced to More Options * Switch Priority and Severity
Created attachment 160360 [details] commited changes changes of comment#31
Created attachment 160361 [details] mylyn/context/zip
I think it is time to close this. If you find some more points please reopen this ore create a new one.
*** Bug 308586 has been marked as a duplicate of this bug. ***
