Community
Participate
Working Groups
Now there there is support for editing custom fields in the bugzilla editor, it would be nice if a user could create a query over the custom fields in bugzill using the rich query editor instead of using the URL.
Will raise in 3.4 planning
I start working on this. I think we should support Charts for all fields an not only for custom fields. Thoughts?
Frank, what do you have in mind for the design of user interface to support charts and custom fields? (In reply to comment #2) > I think we should support Charts for all fields an not only for custom fields. That makes sense to me.
(In reply to comment #3) > Frank, what do you have in mind for the design of user interface to support > charts and custom fields? I want to try to keep this like the /query.cgi#chart UI. So we may need an scroller. Or should we use to tab controls one for the current fields under "More Options" and the other for the Chart Controls. But I thine we also need the scroller. Thoughts?
Created attachment 181786 [details] example
I would prefer if we discussed this on the next Mylyn call first. I think it would be a great addition but we should be careful about adding a lot of extra complexity to an already crowded dialog.
(In reply to comment #6) > I would prefer if we discussed this on the next Mylyn call first. I think it > would be a great addition but we should be careful about adding a lot of extra > complexity to an already crowded dialog. OK so I first try to manage the background work.
Created attachment 182765 [details] screenshot here is a screenshot of my current UI state. Only the negate checkbox is not implemented. I think we should do an redesign of the whole dialog. Maybe we should use a similar UI like Bugzilla 4.? OR should we use tabs instead of expands? Thoughts?
Created attachment 182766 [details] current implematation Her are my changes. If you want to try it out.
Created attachment 182767 [details] mylyn/context/zip
Thanks. I'll add this as a discussion item for next week's call. Can you post a screenshot of the Bugzilla 4 UI?
Created attachment 183027 [details] screenshot of Bugzilla 4.0 UI you can use http://mylyn.eclipse.org/bugshead/query.cgi to see this in action.
We did a quick UI review on today's call. The proposed design looks pretty good and everyone liked it. Here are some suggestions: * Remove all groups except for the inner most grouping around connected OR rows. * Try reducing horizontal spacing withing OR groups. The following questions came up: * Is it necessary to support multiple charts? What is the difference to adding another "And" row? * How can rows or charts be deleted? Is an extra control for deleting needed?
Created attachment 188185 [details] patch V2 (In reply to comment #13) > We did a quick UI review on today's call. The proposed design looks pretty good > and everyone liked it. > > Here are some suggestions: > > * Remove all groups except for the inner most grouping around connected OR rows. > * Try reducing horizontal spacing withing OR groups. > This is in this patch! Should we do an review or can I commit this? > The following questions came up: > > * Is it necessary to support multiple charts? What is the difference to adding > another "And" row? This is because you can negate a chart > * How can rows or charts be deleted? Is an extra control for deleting needed? If a field is "---" it is removed when you save the query.
Created attachment 188187 [details] mylyn/context/zip
Let's do a quick review on the call tomorrow committing. I have added this to the agenda.
Created attachment 188209 [details] example of the patch V2 UI
(In reply to comment #16) > Let's do a quick review on the call tomorrow committing. I have added this to > the agenda. Maybe you can also look forhttps://bugs.eclipse.org/bugs/show_bug.cgi?id=335278#c10 where I describe an new UI for the search page.
This is looking pretty good. Notes from the UI review: * Call the new section "Boolean Charts (Advanced)". * Set a minimum height for list boxes and add a vertical scroll bar as needed. * Remove the border if adding a new chart and use a single separator line between charts instead. * Consider changing the "OR" buttons to "X" once pressed to allow users to remove lines. * Remove indentation for Boolean Chart section content. * Negate is a bit confusing as it applies to chart above the check box. Not sure how we can best address this without using up vertical space. * "negate" should be "Negate" * "New chart" should be "Add Chart" I had a number of problems with the layout: * The main section does not grow to all available space when resizing the dialog * If I press "And" the UI is not updated until I toggle a section * I got exceptions: org.eclipse.swt.SWTException: Widget is disposed at org.eclipse.swt.SWT.error(SWT.java:4209) at org.eclipse.swt.SWT.error(SWT.java:4124) at org.eclipse.swt.SWT.error(SWT.java:4095) at org.eclipse.swt.widgets.Widget.error(Widget.java:466) at org.eclipse.swt.widgets.Widget.checkWidget(Widget.java:403) at org.eclipse.swt.widgets.Button.setSelection(Button.java:905) at org.eclipse.mylyn.internal.bugzilla.ui.search.BugzillaSearchPage.refreshChartControls(BugzillaSearchPage.java:2887) ... I wonder if there is a good way to make this kind of UI with the scrolling and nested sections commons so other connectors could use it as well?
OK I start with this now! Hope that I can refactor a new common class.
You can put the common abstractions that are query page specific in AbstractRepositoryQueryPage2. SectionComposite already provides a UI component with some of the support that we need for this.
Created attachment 188628 [details] patch V3 committed patch. Steffen can you please verify and comment on the new layout.
Created attachment 188629 [details] mylyn/context/zip
That's great! I like the green background color :). I'll do some more testing and add this to an upcoming meeting agenda for another UI review. Can you attach a Mac screenshot?
Created attachment 188651 [details] Mac sreenshot Here the requested screenshot. Sorry the green color was only to see if there is no error by setting the background.
Steffen, What was the result of your tests? Can I close this? Frank
We are almost done here :). Just a few minor nits remaining: * The Boolean Charts composite has a margin that should be removed. * Can we make the "Or" buttons turn into "X" buttons once a new row is added? I tried pressing Ctrl but it didn't work on my system and it's difficult to discover. * Is it possible to increase the minimum height for the Product, Priority etc. list boxes? I think they should at least display three rows.
Just noticed a regression: More Options is not expanded when the query dialog is opened and a Milestone was selected for a query.
Created attachment 189135 [details] patch V4 (In reply to comment #27) > We are almost done here :). Just a few minor nits remaining: > > * The Boolean Charts composite has a margin that should be removed. Sorry I found no way to remove this. > * Can we make the "Or" buttons turn into "X" buttons once a new row is added? I > tried pressing Ctrl but it didn't work on my system and it's difficult to > discover. Now we use SHIFT(MOD2) and no longer CTRL (MOD4 on MAC) see copy from SWT.class: /* * These values can be different on different platforms. * Therefore they are not initialized in the declaration * to stop the compiler from inlining. */ String platform = getPlatform (); if ("carbon".equals (platform) || "cocoa".equals (platform)) { //$NON-NLS-1$ //$NON-NLS-2$ MOD1 = COMMAND; MOD2 = SHIFT; MOD3 = ALT; MOD4 = CONTROL; } else { MOD1 = CONTROL; MOD2 = SHIFT; MOD3 = ALT; MOD4 = 0; } > * Is it possible to increase the minimum height for the Product, Priority etc. > list boxes? I think they should at least display three rows. Change to four lines. (In reply to comment #28) > Just noticed a regression: More Options is not expanded when the query dialog is > opened and a Milestone was selected for a query. more and chart are now expanded
Created attachment 189136 [details] mylyn/context/zip
The next button in the new query wizard is no longer greyed out but doesn't do anything.
Thanks. I have removed some nested composites that weren't required and tweaked the margins some. I noticed that clear does not clear the boolean charts. Frank, can you look into that and comment#31?
Reopening to address comment#31 and comment#32.
(In reply to comment #33) > Reopening to address comment#31 and comment#32. Done!
This is badly broken for me. I cannot search for bugs at all. When I open the search dialog, the Boolean Charts section is expanded as shown, and clicking clear fields has no effect, but when I do any search (e.g. bugs assigned to me) I get no results.
Created attachment 189525 [details] expanded boolean charts
I was able to fix myself by repeatedly collapsing and expanding the section and clicking clear fields, and now I can't get it into the bad state it was in, but I have been in that bad state before (I had assumed the problem had been fixed). I may not be completely up to date though because pserver access was out of date for several days.
(In reply to comment #36) > Created attachment 189525 [details] > expanded boolean charts Sam that screenshot is the presentation for an empty boolean chart. But I do not know why you get this expanded when you open the page. If you can reproduce this or find other problems please reoppen this bug.
