Community
Participate
Working Groups
Created attachment 149318 [details] Solution preview This kind of wrapping is requested?
Created attachment 149319 [details] A patch
Created attachment 149320 [details] mylyn/context/zip
Christopher, do you have a screen snap of what it looked like before the proposed wrapping (for side by side comparison)...was it just a horizontal scrollbar and very wide text? Depending on the error, and how useful the error detail text is worded, I can see how wrapping might make it look worse. I'm wondering if we want to give the user some dynamic control here.
Created attachment 149407 [details] No wrapping
(In reply to comment #4) > Depending on the error, and how useful the error > detail text is worded, I can see how wrapping might make it look worse. Actually I'd expect that wrapping preserves paragraph indentation, I mean very long message should be wrapped as very long message and not as very long message But that kind of improvement either complicated text formatting. This is actually something that I'd like to avoid.
(In reply to comment #6) > (In reply to comment #4) > > Depending on the error, and how useful the error > > detail text is worded, I can see how wrapping might make it look worse. > > Actually I'd expect that wrapping preserves paragraph indentation, I mean > > very long message > > should be wrapped as > > very > long > message > > and not as > very > long message > > But that kind of improvement either complicated text formatting. This is > actually something that I'd like to avoid. I would expect the same thing. The current wrapping looks rather unpolished. Can we accomplish something by using StyledText and setLineIndent(...)? If we could get the indentation correct, then I think we could just wrap it and not worry about providing a dynamic option to unwrap.
setLineIndent indents only first line. It gaves the same messy effect. I am afraid this issue cannot be solved without dirty hacking unless bug 265591 is fixed.
Removing milestone as this bug will not be fixed until it will be possible to indent whole paragraphs,
(In reply to comment #9) > Removing milestone as this bug will not be fixed until it will be possible to > indent whole paragraphs, Christopher, I wonder if we should release the wrapping as currently provided by StyledText. That should surely raise the visibility of the blocking bug? What do you think?
I am afraid it is not a good solution. Note that the indent level is used for marking nesting level. Wrapping in current shapes makes that information unreadable. I am sure we will get a lot of bug reports if the patch is released now. As per information received from Felipe, chances for getting blocker fixed are low. If I have time I'll try to at least recognize if I am able to provide a patch for StyledText.
Created attachment 151057 [details] Adoption of setLineWrapIndent Two examples: LEFT indenting first line a little bit more than others RIGHT consistent indentation for all lines in a paragraph Which is better? (I'd choose the first one).
I agree. I like the small indent. More readable. Two suggestions/questions: 1-Can we get rid of the small indent for the very first one, it looks like a bug on first glance. 2 - Is that first "paragraph" always going to be a duplication of the message text in the top of the dialog? If so, why do we show it at all? We could start with the NullPointerException. As a client, I've gotten bugs that say "why do you repeat the error information?" and worse, if there is no more detail than what is shown up top, it is annoying to open details and get a rehash of what you've already seen. (Maybe I should open a separate bug on that?)
1. Yes. 2. I have opened new bug 294026.
Created attachment 151166 [details] No indent in the first paragraph.
Patch released on 2009-11-03
verified. Wrapping works correctly.
