Comment 1 Francois Chouinard 2009-08-25 10:11:51 EDT

I had a problem generating a patch so I commited a fix directly :-(

- Moved the test code and stubs to the (new) org.eclipse.linuxtools.tests plugin
- Changes version from 1.0.0 to 0.0.1 (we are not ready for prime time yet)
- Fixed few Java 5 issues (should complete Bug 287546)

Comment 2 Francois Chouinard 2009-08-25 10:15:39 EDT

Now, that was a pain...

Comment 3 Andrew Overholt 2009-08-26 10:30:23 EDT

Hi Francois,

Was this a typo:  "Moved the test code and stubs to the (new) org.eclipse.linuxtools.tests plugin"?  Because we already had an org.eclipse.linuxtools.tests plugin, I'm pretty sure.  Or maybe it was named org.eclipse.linuxtools.test and .tests is the feature?

Thanks,

Andrew

Comment 4 Francois Chouinard 2009-08-26 16:59:34 EDT

(In reply to comment #3)

Hi Andrew,

In the initial code, everything was in one plugin, with a xxx.test and xxx.stubs package for the test code and test code visibility was controlled through the Runtime/Exported Packages in the manifest.

However, to keep the useful code small(er), I just split the original plugin and moved the test code in its own plugin.

Should we keep code and test code ion the same plugin? I have no strong opinion about this (although one of my colleagues does :-), so if you have some guidelines that I missed, I'd be happy to hear about them :-)

Best Regards,
/fc

Comment 5 Andrew Overholt 2009-08-27 10:56:01 EDT

Hi Francois,

I recommend separating the tests.  So you end up with:

org.eclipse.linuxtools.tmf.core
org.eclipse.linuxtools.tmf.core.tests

Andrew

Comment 6 Francois Chouinard 2009-08-27 11:58:45 EDT

Hi Andrew,

I believe they are already separate. Do you want me to add "core" to the plugin names?

/fc

Comment 7 Andrew Overholt 2009-08-27 16:58:14 EDT

That's fine, I was just using "core" as an example.  If they're separate, that's what matters.

Comment 8 Francois Chouinard 2010-07-08 10:12:51 EDT

Released in a past delivery.