Comment 1 Remy Suen 2009-06-20 09:39:53 EDT

Created attachment 139671 [details]
CTabItem foreground colours patch v1

This should do it.

Comment 2 Remy Suen 2009-07-11 19:04:07 EDT

Created attachment 141362 [details]
CTabItem foreground colours patch v2

This new patch corrects the getForeground() method to return the parent folder's foreground colour if no foreground colour was set on the item instead of simply returning null.

Comment 3 Remy Suen 2009-07-12 07:36:08 EDT

While reviewing my code, I realized that it may be better to check whether the tab item isShowing() before requesting a redraw from the parent. On the other hand, I noticed that setText(String) doesn't perform this check. Is this intentional? It doesn't seem to make a lot of sense to redraw all the tabs when a hidden tab's text has changed.

Comment 4 Remy Suen 2009-08-24 13:28:07 EDT

Any plans for this? This would help improve our CSS story by providing users with more customizations. Would be happy to correct my patch if necessary. :)

Comment 5 Remy Suen 2010-07-23 19:36:32 EDT

Is there any interest in this for 3.7?

Comment 6 Felipe Heidrich 2010-07-26 09:27:56 EDT

AFAIK the new implementation of CTabFolder offers a complete custom draw solution.

Bog, should we close this as fixed you think ?

Comment 7 Remy Suen 2010-07-26 09:30:47 EDT

(In reply to comment #6)
> AFAIK the new implementation of CTabFolder offers a complete custom draw
> solution.

That's a lot of work just to change colours. :|

Comment 8 Remy Suen 2010-07-26 09:32:08 EDT

If you're going to kill this one then bug 72682 and bug 75411 should probably be killed too then I guess.

Comment 9 Felipe Heidrich 2010-07-26 09:49:04 EDT

I'm not sure if it is worth for us to invest in the "old implementation" of CTabFolder now that we have a new one.

It is up to Bogdan to decide.
Maybe we can write a snippet on how to use the new CTabFolder to only change foreground color.

Comment 10 Remy Suen 2010-07-26 09:54:45 EDT

(In reply to comment #8)
> If you're going to kill this one then bug 72682

Sorry, that should've been bug 72862.

Comment 11 Eclipse Webmaster 2019-09-06 16:16:43 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.