Bug 277037 - [content assist] Completion proposal filter calls hide() instead of hideWhenNoProposals()
Summary: [content assist] Completion proposal filter calls hide() instead of hideWhenN...
Status: RESOLVED DUPLICATE of bug 19733
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.4.2   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-Text-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-19 20:21 EDT by Scott Evans CLA
Modified: 2009-05-20 02:37 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Scott Evans CLA 2009-05-19 20:21:14 EDT
Build ID: M20090211-1700

Steps To Reproduce:
1. Create a ContentAssistant "ca".
2. ca.setShowEmptyList(true);
3. In your app, bring up the content assistant and start filtering until there are no matches.

Result: Proposals are hidden.
Expected result: Proposals don't get hidden until my code calls hide().



More information:
If I'm understanding this right, the behavior I would see is that simply filtering out all results wouldn't hide the propsal window; I would see an empty one with a "no proposals" message, and then if I started deleting characters in my filter, I'd be able to see proposals again.

If that's right, it looks like the problem is in org.eclipse.jface.text.contentassist.CompletionProposalPopup.fFilterRunnable.
The last line below should call hideWhenNoProposals():

379 | if (proposals != null && proposals.length > 0)
380 |   setProposals(proposals, fIsFilteredSubset);
381 | else
382 |   hide();
Comment 1 Dani Megert CLA 2009-05-20 02:37:01 EDT
The setShowEmptyList API is only to decided whether to show it at all. It is not intended to control what to do with an already opened list once it gets empty.

*** This bug has been marked as a duplicate of bug 19733 ***